You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/08/02 05:13:59 UTC
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#2777: NO-JIRA Fix NoProcessFilesBehind build on IBM JDK 8
brusdev commented on a change in pull request #2777: NO-JIRA Fix NoProcessFilesBehind build on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2777#discussion_r309984041
##########
File path: artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/NoProcessFilesBehind.java
##########
@@ -105,7 +105,7 @@ private static int getProcessId() throws ReflectiveOperationException {
java.lang.management.RuntimeMXBean runtime = java.lang.management.ManagementFactory.getRuntimeMXBean();
java.lang.reflect.Field jvmField = runtime.getClass().getDeclaredField("jvm");
jvmField.setAccessible(true);
- sun.management.VMManagement jvm = (sun.management.VMManagement) jvmField.get(runtime);
Review comment:
The class com.sun.management.UnixOperatingSystemMXBean LGTM, as matter of fact I executed NoProcessFilesBehind.getOpenFD with IBM JDK 8 and I got the right open file descriptor count.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services