You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2019/01/02 23:52:16 UTC
[royale-asjs] branch develop updated (cea97a2 -> d3aeb5a)
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
from cea97a2 revert 52fb132168eede607b6615093ae58b99046837a9 and have compiler call a special method instead
new 7fd5f0b use ContainerDataBinding. ApplicationDataBinding is probably ok for Basic Application's lifecycle, but for emulation, the viewChange was firing before the elements in the view were created so binding was firing off too soon.
new d3aeb5a update if form item label changes late (due to binding or handlers)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../projects/MXRoyale/src/main/royale/mx/containers/FormItem.as | 3 +++
frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as | 3 +--
.../SparkRoyale/src/main/royale/spark/components/Application.as | 4 ++--
3 files changed, 6 insertions(+), 4 deletions(-)
[royale-asjs] 02/02: update if form item label changes late (due to
binding or handlers)
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d3aeb5a93ad1ced243e4dcc602f4a08a95c56f20
Author: Alex Harui <ah...@apache.org>
AuthorDate: Wed Jan 2 15:52:03 2019 -0800
update if form item label changes late (due to binding or handlers)
---
frameworks/projects/MXRoyale/src/main/royale/mx/containers/FormItem.as | 3 +++
1 file changed, 3 insertions(+)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/FormItem.as b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/FormItem.as
index ea39c65..613799d 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/FormItem.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/FormItem.as
@@ -347,7 +347,10 @@ public class FormItem extends Container
// Changing the label could affect the overall form label width
// so we need to invalidate our parent's size here too
if (parent is Form)
+ {
Form(parent).invalidateLabelWidth();
+ commitProperties();
+ }
dispatchEvent(new Event("labelChanged"));
}
[royale-asjs] 01/02: use ContainerDataBinding.
ApplicationDataBinding is probably ok for Basic Application's lifecycle,
but for emulation,
the viewChange was firing before the elements in the view were created so
binding was firing off too soon.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 7fd5f0b460fb8a8f9ca0dfb5f64e9e5bd8eb6488
Author: Alex Harui <ah...@apache.org>
AuthorDate: Wed Jan 2 15:51:33 2019 -0800
use ContainerDataBinding. ApplicationDataBinding is probably ok for Basic Application's lifecycle, but for emulation, the viewChange was firing before the elements in the view were created so binding was firing off too soon.
---
frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as | 3 +--
.../SparkRoyale/src/main/royale/spark/components/Application.as | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as b/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as
index 800f3a2..68f0de1 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as
@@ -66,7 +66,6 @@ COMPILE::JS {
import org.apache.royale.core.HTMLElementWrapper;
}
-import org.apache.royale.binding.ApplicationDataBinding;
import org.apache.royale.binding.ContainerDataBinding;
import org.apache.royale.core.AllCSSValuesImpl;
import org.apache.royale.core.IBead;
@@ -309,7 +308,7 @@ public class Application extends Container implements IStrand, IParent, IEventDi
typeNames += " Application";
this.valuesImpl = new AllCSSValuesImpl();
- addBead(new ApplicationDataBinding());
+ addBead(new ContainerDataBinding()); // ApplicationDataBinding fires too soon
addBead(new ApplicationLayout());
instanceParent = this;
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as
index 86d92a8..f52989c 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as
@@ -70,7 +70,7 @@ COMPILE::JS {
import org.apache.royale.core.HTMLElementWrapper;
}
-import org.apache.royale.binding.ApplicationDataBinding;
+import org.apache.royale.binding.ContainerDataBinding;
import org.apache.royale.core.AllCSSValuesImpl;
import org.apache.royale.core.IFlexInfo;
import org.apache.royale.core.IParent;
@@ -318,7 +318,7 @@ public class Application extends SkinnableContainer implements IStrand, IParent,
initResizeBehavior(); */
this.valuesImpl = new AllCSSValuesImpl();
- addBead(new ApplicationDataBinding());
+ addBead(new ContainerDataBinding());
COMPILE::JS
{