You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "l2280212 (via GitHub)" <gi...@apache.org> on 2023/03/14 08:00:07 UTC
[GitHub] [iotdb] l2280212 opened a new pull request, #9320: [IOTDB-5616] Fix some code smells
l2280212 opened a new pull request, #9320:
URL: https://github.com/apache/iotdb/pull/9320
fix some code smells，please see in [JIRA5616](https://issues.apache.org/jira/browse/IOTDB-5616).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #9320: [IOTDB-5616] Fix some code smells
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #9320:
URL: https://github.com/apache/iotdb/pull/9320#discussion_r1135283003
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java:
##########
@@ -364,7 +364,10 @@ private void flushWALForSimpleConsensus() {
private void createLogFile(int endIndex) {
simpleLogFile = SystemFileFactory.INSTANCE.getFile(PROGRESS_FILE_PATH + endIndex);
try {
- simpleLogFile.createNewFile();
+ if (!simpleLogFile.createNewFile())
Review Comment:
add `{` and `}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] l2280212 commented on a diff in pull request #9320: [IOTDB-5616] Fix some code smells
Posted by "l2280212 (via GitHub)" <gi...@apache.org>.
l2280212 commented on code in PR #9320:
URL: https://github.com/apache/iotdb/pull/9320#discussion_r1135729640
##########
confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java:
##########
@@ -364,7 +364,10 @@ private void flushWALForSimpleConsensus() {
private void createLogFile(int endIndex) {
simpleLogFile = SystemFileFactory.INSTANCE.getFile(PROGRESS_FILE_PATH + endIndex);
try {
- simpleLogFile.createNewFile();
+ if (!simpleLogFile.createNewFile())
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SpriCoder merged pull request #9320: [IOTDB-5616] Fix some code smells
Posted by "SpriCoder (via GitHub)" <gi...@apache.org>.
SpriCoder merged PR #9320:
URL: https://github.com/apache/iotdb/pull/9320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org