You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/05/02 18:04:43 UTC
[PR] Add .note section to embed_bundle_linux.s to prevent executable stack (celix)
pnoltes opened a new pull request, #535:
URL: https://github.com/apache/celix/pull/535
This PR adds the .section .note.GNU-stack,"",%progbits directive to the embed_bundle_linux.s template file. This change addresses the "missing .note.GNU-stack section implies executable stack" warning from ld.
By adding this directive, we explicitly signal to the linker that the object file does not require an executable stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add .note section to embed_bundle_linux.s to prevent executable stack (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #535:
URL: https://github.com/apache/celix/pull/535#issuecomment-1531940815
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/535?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#535](https://app.codecov.io/gh/apache/celix/pull/535?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26db310) into [master](https://app.codecov.io/gh/apache/celix/commit/c63c63531c38dd54feecdf6fb6439beb19db8074?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c63c635) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 26db310 differs from pull request most recent head 8718b9f. Consider uploading reports for the commit 8718b9f to get more accurate results
```diff
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 75.65% 75.64% -0.02%
==========================================
Files 225 225
Lines 34439 34439
==========================================
- Hits 26056 26051 -5
- Misses 8383 8388 +5
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/535/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add .note section to embed_bundle_linux.s to prevent executable stack (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #535:
URL: https://github.com/apache/celix/pull/535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org