You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Uwe Schindler <uw...@thetaphi.de> on 2011/01/05 20:24:54 UTC

RE: svn commit: r1055587 - in /lucene/dev/branches/branch_3x/lucene: ./ contrib/remote/src/java/org/apache/lucene/search/ src/java/org/apache/lucene/search/

What happens with PMS? Maybe we should backport the parallelization of IndexSearcher to 3.x! Then we can also deprecate.

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de


> -----Original Message-----
> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
> Sent: Wednesday, January 05, 2011 8:15 PM
> To: commits@lucene.apache.org
> Subject: svn commit: r1055587 - in /lucene/dev/branches/branch_3x/lucene:
> ./ contrib/remote/src/java/org/apache/lucene/search/
> src/java/org/apache/lucene/search/
> 
> Author: mikemccand
> Date: Wed Jan  5 19:14:47 2011
> New Revision: 1055587
> 
> URL: http://svn.apache.org/viewvc?rev=1055587&view=rev
> Log:
> LUCENE-2837: deprecate classes in 3.x
> 
> Modified:
>     lucene/dev/branches/branch_3x/lucene/CHANGES.txt
> 
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RMIRemoteSearchable.java
> 
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteCachingWrapperFilter.java
> 
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteSearchable.java
> 
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/MultiSearcher.java
> 
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searchable.java
> 
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searcher.java
> 
> Modified: lucene/dev/branches/branch_3x/lucene/CHANGES.txt
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/CHA
> NGES.txt?rev=1055587&r1=1055586&r2=1055587&view=diff
> ==========================================================
> ====================
> --- lucene/dev/branches/branch_3x/lucene/CHANGES.txt (original)
> +++ lucene/dev/branches/branch_3x/lucene/CHANGES.txt Wed Jan  5
> 19:14:47 2011
> @@ -77,6 +77,10 @@ Changes in backwards compatibility polic
>  * LUCENE-2804: Directory.setLockFactory new declares throwing an
> IOException.
>    (Shai Erera, Robert Muir)
> 
> +* LUCENE-2837: Added deprecations noting that in 4.0, Searcher and
> +  Searchable are collapsed into IndexSearcher; contrib/remote and
> +  MultiSearcher have been removed.  (Mike McCandless)
> +
>  Changes in runtime behavior
> 
>  * LUCENE-1923: Made IndexReader.toString() produce something
> 
> Modified:
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RMIRemoteSearchable.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/con
> trib/remote/src/java/org/apache/lucene/search/RMIRemoteSearchable.jav
> a?rev=1055587&r1=1055586&r2=1055587&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RMIRemoteSearchable.java (original)
> +++
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RMIRemoteSearchable.java Wed Jan  5 19:14:47 2011
> @@ -38,7 +38,11 @@ import java.rmi.Remote;
>   *
>   * </p>
>   * </p>
> + *
> + * @deprecated This package (all of contrib/remote) will be
> + * removed in 4.0.
>   */
> +@Deprecated
>  public interface RMIRemoteSearchable extends Searchable, Remote {
> 
>  }
> 
> Modified:
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteCachingWrapperFilter.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/con
> trib/remote/src/java/org/apache/lucene/search/RemoteCachingWrapperFilt
> er.java?rev=1055587&r1=1055586&r2=1055587&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteCachingWrapperFilter.java (original)
> +++
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteCachingWrapperFilter.java Wed Jan  5 19:14:47
> 2011
> @@ -35,7 +35,11 @@ import org.apache.lucene.index.IndexRead
>   * To cache a result you must do something like
>   * RemoteCachingWrapperFilter f = new RemoteCachingWrapperFilter(new
> CachingWrapperFilter(myFilter));
>   * <p/>
> + *
> + * @deprecated This package (all of contrib/remote) will be
> + * removed in 4.0.
>   */
> +@Deprecated
>  public class RemoteCachingWrapperFilter extends Filter {
>    protected Filter filter;
> 
> 
> Modified:
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteSearchable.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/con
> trib/remote/src/java/org/apache/lucene/search/RemoteSearchable.java?re
> v=1055587&r1=1055586&r2=1055587&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteSearchable.java (original)
> +++
> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
> he/lucene/search/RemoteSearchable.java Wed Jan  5 19:14:47 2011
> @@ -32,7 +32,11 @@ import java.rmi.server.UnicastRemoteObje
> 
>  /**
>   * A remote searchable implementation.
> + *
> + * @deprecated This package (all of contrib/remote) will be
> + * removed in 4.0.
>   */
> +@Deprecated
>  public class RemoteSearchable
>    extends UnicastRemoteObject
>    implements RMIRemoteSearchable {
> 
> Modified:
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/MultiSearcher.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/src/
> java/org/apache/lucene/search/MultiSearcher.java?rev=1055587&r1=10555
> 86&r2=1055587&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/MultiSearcher.java (original)
> +++
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/MultiSearcher.java Wed Jan  5 19:14:47 2011
> @@ -37,7 +37,13 @@ import java.util.concurrent.locks.Lock;
>   *
>   * <p>Applications usually need only call the inherited {@link
> #search(Query,int)}
>   * or {@link #search(Query,Filter,int)} methods.
> + *
> + * @deprecated If you are using MultiSearcher over
> + * IndexSearchers, please use MultiReader instead; this class
> + * does not properly handle certain kinds of queries (see <a
> + * href="https://issues.apache.org/jira/browse/LUCENE-2756">LUCENE-
> 2756</a>).
>   */
> +@Deprecated
>  public class MultiSearcher extends Searcher {
> 
>    /**
> 
> Modified:
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searchable.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/src/
> java/org/apache/lucene/search/Searchable.java?rev=1055587&r1=1055586&
> r2=1055587&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searchable.java (original)
> +++
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searchable.java Wed Jan  5 19:14:47 2011
> @@ -41,7 +41,11 @@ import org.apache.lucene.index.Term;
>   * <b>NOTE:</b> this interface is kept public for convenience. Since it is not
>   * expected to be implemented directly, it may be changed unexpectedly
> between
>   * releases.
> + *
> + * @deprecated In 4.0 this interface is removed/absorbed
> + * into IndexSearcher
>   */
> +@Deprecated
>  public interface Searchable extends Closeable {
> 
>    /**
> 
> Modified:
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searcher.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/src/
> java/org/apache/lucene/search/Searcher.java?rev=1055587&r1=1055586&r2
> =1055587&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searcher.java (original)
> +++
> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
> h/Searcher.java Wed Jan  5 19:14:47 2011
> @@ -31,7 +31,11 @@ import org.apache.lucene.document.FieldS
>   * <p>
>   * Note that you can only access hits from a Searcher as long as it is not yet
>   * closed, otherwise an IOException will be thrown.
> + *
> + * @deprecated In 4.0 this abstract class is removed/absorbed
> + * into IndexSearcher
>   */
> +@Deprecated
>  public abstract class Searcher implements Searchable {
>    /** Search implementation with arbitrary sorting.  Finds
>     * the top <code>n</code> hits for <code>query</code>, applying
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: svn commit: r1055587 - in /lucene/dev/branches/branch_3x/lucene: ./ contrib/remote/src/java/org/apache/lucene/search/ src/java/org/apache/lucene/search/

Posted by Michael McCandless <lu...@mikemccandless.com>.
Good idea!  I'll reopen...

Mike

On Wed, Jan 5, 2011 at 2:24 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> What happens with PMS? Maybe we should backport the parallelization of IndexSearcher to 3.x! Then we can also deprecate.
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>> -----Original Message-----
>> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
>> Sent: Wednesday, January 05, 2011 8:15 PM
>> To: commits@lucene.apache.org
>> Subject: svn commit: r1055587 - in /lucene/dev/branches/branch_3x/lucene:
>> ./ contrib/remote/src/java/org/apache/lucene/search/
>> src/java/org/apache/lucene/search/
>>
>> Author: mikemccand
>> Date: Wed Jan  5 19:14:47 2011
>> New Revision: 1055587
>>
>> URL: http://svn.apache.org/viewvc?rev=1055587&view=rev
>> Log:
>> LUCENE-2837: deprecate classes in 3.x
>>
>> Modified:
>>     lucene/dev/branches/branch_3x/lucene/CHANGES.txt
>>
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RMIRemoteSearchable.java
>>
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteCachingWrapperFilter.java
>>
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteSearchable.java
>>
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/MultiSearcher.java
>>
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searchable.java
>>
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searcher.java
>>
>> Modified: lucene/dev/branches/branch_3x/lucene/CHANGES.txt
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/CHA
>> NGES.txt?rev=1055587&r1=1055586&r2=1055587&view=diff
>> ==========================================================
>> ====================
>> --- lucene/dev/branches/branch_3x/lucene/CHANGES.txt (original)
>> +++ lucene/dev/branches/branch_3x/lucene/CHANGES.txt Wed Jan  5
>> 19:14:47 2011
>> @@ -77,6 +77,10 @@ Changes in backwards compatibility polic
>>  * LUCENE-2804: Directory.setLockFactory new declares throwing an
>> IOException.
>>    (Shai Erera, Robert Muir)
>>
>> +* LUCENE-2837: Added deprecations noting that in 4.0, Searcher and
>> +  Searchable are collapsed into IndexSearcher; contrib/remote and
>> +  MultiSearcher have been removed.  (Mike McCandless)
>> +
>>  Changes in runtime behavior
>>
>>  * LUCENE-1923: Made IndexReader.toString() produce something
>>
>> Modified:
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RMIRemoteSearchable.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/con
>> trib/remote/src/java/org/apache/lucene/search/RMIRemoteSearchable.jav
>> a?rev=1055587&r1=1055586&r2=1055587&view=diff
>> ==========================================================
>> ====================
>> ---
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RMIRemoteSearchable.java (original)
>> +++
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RMIRemoteSearchable.java Wed Jan  5 19:14:47 2011
>> @@ -38,7 +38,11 @@ import java.rmi.Remote;
>>   *
>>   * </p>
>>   * </p>
>> + *
>> + * @deprecated This package (all of contrib/remote) will be
>> + * removed in 4.0.
>>   */
>> +@Deprecated
>>  public interface RMIRemoteSearchable extends Searchable, Remote {
>>
>>  }
>>
>> Modified:
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteCachingWrapperFilter.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/con
>> trib/remote/src/java/org/apache/lucene/search/RemoteCachingWrapperFilt
>> er.java?rev=1055587&r1=1055586&r2=1055587&view=diff
>> ==========================================================
>> ====================
>> ---
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteCachingWrapperFilter.java (original)
>> +++
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteCachingWrapperFilter.java Wed Jan  5 19:14:47
>> 2011
>> @@ -35,7 +35,11 @@ import org.apache.lucene.index.IndexRead
>>   * To cache a result you must do something like
>>   * RemoteCachingWrapperFilter f = new RemoteCachingWrapperFilter(new
>> CachingWrapperFilter(myFilter));
>>   * <p/>
>> + *
>> + * @deprecated This package (all of contrib/remote) will be
>> + * removed in 4.0.
>>   */
>> +@Deprecated
>>  public class RemoteCachingWrapperFilter extends Filter {
>>    protected Filter filter;
>>
>>
>> Modified:
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteSearchable.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/con
>> trib/remote/src/java/org/apache/lucene/search/RemoteSearchable.java?re
>> v=1055587&r1=1055586&r2=1055587&view=diff
>> ==========================================================
>> ====================
>> ---
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteSearchable.java (original)
>> +++
>> lucene/dev/branches/branch_3x/lucene/contrib/remote/src/java/org/apac
>> he/lucene/search/RemoteSearchable.java Wed Jan  5 19:14:47 2011
>> @@ -32,7 +32,11 @@ import java.rmi.server.UnicastRemoteObje
>>
>>  /**
>>   * A remote searchable implementation.
>> + *
>> + * @deprecated This package (all of contrib/remote) will be
>> + * removed in 4.0.
>>   */
>> +@Deprecated
>>  public class RemoteSearchable
>>    extends UnicastRemoteObject
>>    implements RMIRemoteSearchable {
>>
>> Modified:
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/MultiSearcher.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/src/
>> java/org/apache/lucene/search/MultiSearcher.java?rev=1055587&r1=10555
>> 86&r2=1055587&view=diff
>> ==========================================================
>> ====================
>> ---
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/MultiSearcher.java (original)
>> +++
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/MultiSearcher.java Wed Jan  5 19:14:47 2011
>> @@ -37,7 +37,13 @@ import java.util.concurrent.locks.Lock;
>>   *
>>   * <p>Applications usually need only call the inherited {@link
>> #search(Query,int)}
>>   * or {@link #search(Query,Filter,int)} methods.
>> + *
>> + * @deprecated If you are using MultiSearcher over
>> + * IndexSearchers, please use MultiReader instead; this class
>> + * does not properly handle certain kinds of queries (see <a
>> + * href="https://issues.apache.org/jira/browse/LUCENE-2756">LUCENE-
>> 2756</a>).
>>   */
>> +@Deprecated
>>  public class MultiSearcher extends Searcher {
>>
>>    /**
>>
>> Modified:
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searchable.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/src/
>> java/org/apache/lucene/search/Searchable.java?rev=1055587&r1=1055586&
>> r2=1055587&view=diff
>> ==========================================================
>> ====================
>> ---
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searchable.java (original)
>> +++
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searchable.java Wed Jan  5 19:14:47 2011
>> @@ -41,7 +41,11 @@ import org.apache.lucene.index.Term;
>>   * <b>NOTE:</b> this interface is kept public for convenience. Since it is not
>>   * expected to be implemented directly, it may be changed unexpectedly
>> between
>>   * releases.
>> + *
>> + * @deprecated In 4.0 this interface is removed/absorbed
>> + * into IndexSearcher
>>   */
>> +@Deprecated
>>  public interface Searchable extends Closeable {
>>
>>    /**
>>
>> Modified:
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searcher.java
>> URL:
>> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/src/
>> java/org/apache/lucene/search/Searcher.java?rev=1055587&r1=1055586&r2
>> =1055587&view=diff
>> ==========================================================
>> ====================
>> ---
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searcher.java (original)
>> +++
>> lucene/dev/branches/branch_3x/lucene/src/java/org/apache/lucene/searc
>> h/Searcher.java Wed Jan  5 19:14:47 2011
>> @@ -31,7 +31,11 @@ import org.apache.lucene.document.FieldS
>>   * <p>
>>   * Note that you can only access hits from a Searcher as long as it is not yet
>>   * closed, otherwise an IOException will be thrown.
>> + *
>> + * @deprecated In 4.0 this abstract class is removed/absorbed
>> + * into IndexSearcher
>>   */
>> +@Deprecated
>>  public abstract class Searcher implements Searchable {
>>    /** Search implementation with arbitrary sorting.  Finds
>>     * the top <code>n</code> hits for <code>query</code>, applying
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org