You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2008/08/21 18:02:37 UTC

[PATCH] Add support for ssl client certificate passphrase caching in JavaHL

Hi,

I am attaching a patch along with this email which adds support for ssl client 
certificate caching in JavaHL.

[[[
Add support for ssl client certificate passphrase caching in JavaHL.

* subversion/bindings/javahl/native/SVNClient.cpp
   (get_auth_simple_provider): Moved from here ...
   (get_auth_provider): ... to here with code from libsvn_subr/cmdline.c
   (SVNClient::getContext): Reflect the above change which registers providers
    for GNOME Keyring and Kwallet.

Patch by: stylesen
Found by: markphip
]]]

Thank You.
-- 
Senthil Kumaran S
http://www.stylesen.org/


Re: [PATCH] Add support for ssl client certificate passphrase caching in JavaHL

Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arfrever Frehtes Taifersar Arahesis wrote:
>> * subversion/bindings/javahl/native/SVNClient.cpp
>>    (get_auth_simple_provider): Moved from here ...
>>    (get_auth_provider): ... to here with code from libsvn_subr/cmdline.c
>>    (SVNClient::getContext): Reflect the above change which registers providers
>>     for GNOME Keyring and Kwallet.
> 
> s/Kwallet/KWallet/

I know you will point this, I was careful enough to add 'K' but missed 'W'
somehow :( which you've caught :)

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIro669o1G+2zNQDgRAm9AAKCWJl1H7lROY+LpGdfpOisn8mzZvwCdFJr5
6Bgr2vkO3fuM/u6V8IjJbo0=
=aaQE
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Add support for ssl client certificate passphrase caching in JavaHL

Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Phippard wrote:
> I've been able to test this using Subclipse and can verify that it now
> works properly.  +1 on backporting it to the branch.

Backported r32632 from trunk to 1.5.x-issue2489 branch via r32634.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIrr+B9o1G+2zNQDgRAmhbAKC4wUPrK8hqGRHw4H4C84Et/HT0mACfdFpN
Me+eVffXuuwU79ShOtJQ/7o=
=WqF/
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Add support for ssl client certificate passphrase caching in JavaHL

Posted by Mark Phippard <ma...@gmail.com>.
On Fri, Aug 22, 2008 at 6:33 AM, Senthil Kumaran S <se...@collab.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Arfrever Frehtes Taifersar Arahesis wrote:
>>> [[[
>>> Add support for ssl client certificate passphrase caching in JavaHL.
>>>
>>> * subversion/bindings/javahl/native/SVNClient.cpp
>>>    (get_auth_simple_provider): Moved from here ...
>>>    (get_auth_provider): ... to here with code from libsvn_subr/cmdline.c
>>>    (SVNClient::getContext): Reflect the above change which registers providers
>>>     for GNOME Keyring and Kwallet.
>>
>> s/Kwallet/KWallet/
>>
>>> Patch by: stylesen
>>> Found by: markphip
>>> ]]]
>>
>> +1 to commit.
>
> Committed in r32632.

I've been able to test this using Subclipse and can verify that it now
works properly.  +1 on backporting it to the branch.



-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Add support for ssl client certificate passphrase caching in JavaHL

Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arfrever Frehtes Taifersar Arahesis wrote:
>> [[[
>> Add support for ssl client certificate passphrase caching in JavaHL.
>>
>> * subversion/bindings/javahl/native/SVNClient.cpp
>>    (get_auth_simple_provider): Moved from here ...
>>    (get_auth_provider): ... to here with code from libsvn_subr/cmdline.c
>>    (SVNClient::getContext): Reflect the above change which registers providers
>>     for GNOME Keyring and Kwallet.
> 
> s/Kwallet/KWallet/
> 
>> Patch by: stylesen
>> Found by: markphip
>> ]]]
> 
> +1 to commit.

Committed in r32632.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIrpX49o1G+2zNQDgRAnSzAJ0WpwA6845+vzA70yg0Nfv8bIMXVwCfdirt
npF2VbB3SFkvoqAhZC74f2c=
=5aP9
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Add support for ssl client certificate passphrase caching in JavaHL

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-08-21 20:02:37 Senthil Kumaran S napisaƂ(a):
> Hi,
> 
> I am attaching a patch along with this email which adds support for ssl client 
> certificate caching in JavaHL.
> 
> [[[
> Add support for ssl client certificate passphrase caching in JavaHL.
> 
> * subversion/bindings/javahl/native/SVNClient.cpp
>    (get_auth_simple_provider): Moved from here ...
>    (get_auth_provider): ... to here with code from libsvn_subr/cmdline.c
>    (SVNClient::getContext): Reflect the above change which registers providers
>     for GNOME Keyring and Kwallet.

s/Kwallet/KWallet/

> Patch by: stylesen
> Found by: markphip
> ]]]

+1 to commit.

-- 
Arfrever Frehtes Taifersar Arahesis