You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by al...@apache.org on 2015/10/26 16:10:30 UTC

svn commit: r1710617 - in /jackrabbit/oak/branches/1.2: ./ oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/ oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/ oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/

Author: alexparvulescu
Date: Mon Oct 26 15:10:29 2015
New Revision: 1710617

URL: http://svn.apache.org/viewvc?rev=1710617&view=rev
Log:
OAK-3054 IndexStatsMBean should provide some details if the async indexing is failing
 - merged r1710575


Modified:
    jackrabbit/oak/branches/1.2/   (props changed)
    jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/IndexStatsMBean.java
    jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
    jackrabbit/oak/branches/1.2/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdateTest.java

Propchange: jackrabbit/oak/branches/1.2/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Oct 26 15:10:29 2015
@@ -1,3 +1,3 @@
 /jackrabbit/oak/branches/1.0:1665962
-/jackrabbit/oak/trunk:1672350,1672468,1672537,1672603,1672642,1672644,1672834-1672835,1673351,1673410,1673414-1673415,1673436,1673644,1673662-1673664,1673669,1673695,1673713,1673738,1673787,1673791,1674046,1674065,1674075,1674107,1674228,1674780,1674880,1675054-1675055,1675319,1675332,1675354,1675357,1675382,1675555,1675566,1675593,1676198,1676237,1676407,1676458,1676539,1676670,1676693,1676703,1676725,1677579,1677581,1677609,1677611,1677774,1677788,1677797,1677804,1677806,1677939,1677991,1678023,1678095-1678096,1678124,1678171,1678173,1678211,1678323,1678758,1678938,1678954,1679144,1679165,1679191,1679232,1679235,1679503,1679958,1679961,1680170,1680172,1680182,1680222,1680232,1680236,1680461,1680633,1680643,1680747,1680805-1680806,1680903,1681282,1681767,1681918,1681955,1682042,1682218,1682235,1682437,1682494,1682555,1682855,1682904,1683059,1683089,1683213,1683249,1683259,1683278,1683323,1683687,1683700,1684174-1684175,1684186,1684376,1684442,1684561,1684570,1684601,1684618,1684820
 ,1684868,1685023,1685075,1685370,1685552,1685589-1685590,1685840,1685964,1685977,1685989,1685999,1686023,1686032,1686097,1686162,1686229,1686234,1686253,1686414,1686780,1686854,1686857,1686971,1687053-1687055,1687175,1687196,1687198,1687220,1687239-1687240,1687301,1687441,1687553,1688089-1688090,1688172,1688179,1688349,1688421,1688436,1688453,1688616,1688622,1688634,1688636,1688817,1689003-1689004,1689008,1689577,1689581,1689623,1689810,1689828,1689831,1689833,1689903,1690017,1690043,1690047,1690057,1690247,1690249,1690634-1690637,1690650,1690669,1690674,1690885,1690941,1691139,1691151,1691159,1691167,1691183,1691188,1691210,1691280,1691307,1691331-1691333,1691345,1691384-1691385,1691401,1691509,1692133-1692134,1692156,1692250,1692274,1692363,1692382,1692478,1692955,1693002,1693030,1693209,1693421,1693525-1693526,1694007,1694393-1694394,1694651,1694653-1694654,1695032,1695050,1695122,1695280,1695299,1695420,1695457,1695482,1695507,1695521,1695540,1696190,1696194,1696242,1696285,1696
 375,1696522,1696578,1696759,1696916,1697363,1697373,1697410,1697582,1697589,1697616,1697672,1700191,1700231,1700397,1700403,1700506,1700571,1700727,1700749,1700769,1700775,1701065,1701619,1701733,1701743,1701750,1701768,1701806,1701810,1701814,1701948,1701955,1701959,1701965,1701986,1702014,1702022,1702051,1702241,1702272,1702387,1702405,1702423,1702860,1702942,1702960,1703212,1703382,1703395,1703411,1703428,1703430,1703568,1703592,1703758,1703858,1703878,1704256,1704282,1704285,1704457,1704479,1704490,1704614,1704629,1704636,1704655,1704670,1704886,1705005,1705027,1705043,1705055,1705250,1705268,1705273,1705323,1705677,1705701,1705871,1705992,1706212,1706764,1706772,1707049,1707191,1707435,1708105,1708315,1708546,1708592,1708766,1709012,1710031,1710049,1710559
+/jackrabbit/oak/trunk:1672350,1672468,1672537,1672603,1672642,1672644,1672834-1672835,1673351,1673410,1673414-1673415,1673436,1673644,1673662-1673664,1673669,1673695,1673713,1673738,1673787,1673791,1674046,1674065,1674075,1674107,1674228,1674780,1674880,1675054-1675055,1675319,1675332,1675354,1675357,1675382,1675555,1675566,1675593,1676198,1676237,1676407,1676458,1676539,1676670,1676693,1676703,1676725,1677579,1677581,1677609,1677611,1677774,1677788,1677797,1677804,1677806,1677939,1677991,1678023,1678095-1678096,1678124,1678171,1678173,1678211,1678323,1678758,1678938,1678954,1679144,1679165,1679191,1679232,1679235,1679503,1679958,1679961,1680170,1680172,1680182,1680222,1680232,1680236,1680461,1680633,1680643,1680747,1680805-1680806,1680903,1681282,1681767,1681918,1681955,1682042,1682218,1682235,1682437,1682494,1682555,1682855,1682904,1683059,1683089,1683213,1683249,1683259,1683278,1683323,1683687,1683700,1684174-1684175,1684186,1684376,1684442,1684561,1684570,1684601,1684618,1684820
 ,1684868,1685023,1685075,1685370,1685552,1685589-1685590,1685840,1685964,1685977,1685989,1685999,1686023,1686032,1686097,1686162,1686229,1686234,1686253,1686414,1686780,1686854,1686857,1686971,1687053-1687055,1687175,1687196,1687198,1687220,1687239-1687240,1687301,1687441,1687553,1688089-1688090,1688172,1688179,1688349,1688421,1688436,1688453,1688616,1688622,1688634,1688636,1688817,1689003-1689004,1689008,1689577,1689581,1689623,1689810,1689828,1689831,1689833,1689903,1690017,1690043,1690047,1690057,1690247,1690249,1690634-1690637,1690650,1690669,1690674,1690885,1690941,1691139,1691151,1691159,1691167,1691183,1691188,1691210,1691280,1691307,1691331-1691333,1691345,1691384-1691385,1691401,1691509,1692133-1692134,1692156,1692250,1692274,1692363,1692382,1692478,1692955,1693002,1693030,1693209,1693421,1693525-1693526,1694007,1694393-1694394,1694651,1694653-1694654,1695032,1695050,1695122,1695280,1695299,1695420,1695457,1695482,1695507,1695521,1695540,1696190,1696194,1696242,1696285,1696
 375,1696522,1696578,1696759,1696916,1697363,1697373,1697410,1697582,1697589,1697616,1697672,1700191,1700231,1700397,1700403,1700506,1700571,1700727,1700749,1700769,1700775,1701065,1701619,1701733,1701743,1701750,1701768,1701806,1701810,1701814,1701948,1701955,1701959,1701965,1701986,1702014,1702022,1702051,1702241,1702272,1702387,1702405,1702423,1702860,1702942,1702960,1703212,1703382,1703395,1703411,1703428,1703430,1703568,1703592,1703758,1703858,1703878,1704256,1704282,1704285,1704457,1704479,1704490,1704614,1704629,1704636,1704655,1704670,1704886,1705005,1705027,1705043,1705055,1705250,1705268,1705273,1705323,1705677,1705701,1705871,1705992,1706212,1706764,1706772,1707049,1707191,1707435,1708105,1708315,1708546,1708592,1708766,1709012,1710031,1710049,1710559,1710575
 /jackrabbit/trunk:1345480

Modified: jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/IndexStatsMBean.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/IndexStatsMBean.java?rev=1710617&r1=1710616&r2=1710617&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/IndexStatsMBean.java (original)
+++ jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/IndexStatsMBean.java Mon Oct 26 15:10:29 2015
@@ -131,6 +131,13 @@ public interface IndexStatsMBean {
     CompositeData getExecutionTime();
 
     /**
+     * Returns the number of indexed nodes as a {@link org.apache.jackrabbit.api.stats.TimeSeries}.
+     *
+     * @return the indexed nodes time series
+     */
+    CompositeData getIndexedNodesCount();
+
+    /**
      * Returns the consolidated execution stats since last reset
      * @return consolidated execution stats
      */
@@ -140,4 +147,34 @@ public interface IndexStatsMBean {
      * Resets the consolidated stats.
      */
     void resetConsolidatedExecutionStats();
+
+    /**
+     * @return true if the indexing job is failing
+     */
+    boolean isFailing();
+
+    /**
+     * @return The time the indexing job stared failing, or {@code ""} if the
+     *         job is not currently failing.
+     */
+    String getFailingSince();
+
+    /**
+     * @return the number of consecutive failed executions or {@code 0} if the
+     *         job is not currently failing.
+     */
+    long getConsecutiveFailedExecutions();
+
+    /**
+     * @return the latest indexing error seen, will not be reset once the job
+     *         starts working again
+     */
+    String getLatestError();
+
+    /**
+     * @return the time when the latest indexing error has been seen, will not
+     *         be reset once the job starts working again
+     */
+    String getLatestErrorTime();
+
 }

Modified: jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java?rev=1710617&r1=1710616&r2=1710617&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java (original)
+++ jackrabbit/oak/branches/1.2/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java Mon Oct 26 15:10:29 2015
@@ -19,6 +19,8 @@
 package org.apache.jackrabbit.oak.plugins.index;
 
 import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.base.Throwables.getStackTraceAsString;
+import static com.google.common.collect.Sets.newHashSet;
 import static org.apache.jackrabbit.oak.api.jmx.IndexStatsMBean.STATUS_DONE;
 import static org.apache.jackrabbit.oak.commons.PathUtils.elements;
 import static org.apache.jackrabbit.oak.plugins.index.IndexConstants.ASYNC_PROPERTY_NAME;
@@ -40,10 +42,6 @@ import javax.management.openmbean.OpenDa
 import javax.management.openmbean.OpenType;
 import javax.management.openmbean.SimpleType;
 
-import com.google.common.base.Objects;
-import com.google.common.base.Stopwatch;
-import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.Sets;
 import org.apache.jackrabbit.oak.api.CommitFailedException;
 import org.apache.jackrabbit.oak.api.PropertyState;
 import org.apache.jackrabbit.oak.api.Type;
@@ -69,6 +67,12 @@ import org.apache.jackrabbit.util.ISO860
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.google.common.base.Objects;
+import com.google.common.base.Splitter;
+import com.google.common.base.Stopwatch;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Sets;
+
 public class AsyncIndexUpdate implements Runnable {
 
     private static final Logger log = LoggerFactory
@@ -117,9 +121,6 @@ public class AsyncIndexUpdate implements
 
     private final long lifetime = DEFAULT_LIFETIME; // TODO: make configurable
 
-    /** Flag to avoid repeatedly logging failure warnings */
-    private boolean failing = false;
-
     private final AsyncIndexStats indexStats = new AsyncIndexStats();
 
     /** Flag to switch to synchronous updates once the index caught up to the repo */
@@ -135,6 +136,14 @@ public class AsyncIndexUpdate implements
 
     private final MissingIndexProviderStrategy missingStrategy = new DefaultMissingIndexProviderStrategy();
 
+    /**
+     * Controls the length of the interval (in minutes) at which an indexing
+     * error is logged as 'warning'. for the rest of the indexing cycles errors
+     * will be logged at 'debug' level
+     */
+    private static long ERROR_WARN_INTERVAL = TimeUnit.MINUTES.toMillis(Integer
+            .getInteger("oak.async.warn.interval", 30));
+
     public AsyncIndexUpdate(@Nonnull String name, @Nonnull NodeStore store,
             @Nonnull IndexEditorProvider provider, boolean switchOnSync) {
         this.name = checkNotNull(name);
@@ -163,8 +172,6 @@ public class AsyncIndexUpdate implements
         /** Expiration time of the last lease we committed */
         private long lease;
 
-        private long updates = 0;
-
         private final String leaseName;
         private final String tempCpName;
 
@@ -189,7 +196,7 @@ public class AsyncIndexUpdate implements
             mergeWithConcurrencyCheck(builder, checkpoint, beforeLease);
 
             // reset updates counter
-            indexStats.setUpdates(this.updates);
+            indexStats.resetUpdates();
         }
 
         private void updateTempCheckpoints(NodeBuilder async,
@@ -225,7 +232,7 @@ public class AsyncIndexUpdate implements
         }
 
         boolean isDirty() {
-            return updates > 0;
+            return indexStats.getUpdates() > 0;
         }
 
         void close() throws CommitFailedException {
@@ -237,9 +244,7 @@ public class AsyncIndexUpdate implements
 
         @Override
         public void indexUpdate() throws CommitFailedException {
-            updates++;
-            if (updates % 100 == 0) {
-                indexStats.setUpdates(this.updates);
+            if (indexStats.incUpdates() % 100 == 0) {
                 long now = System.currentTimeMillis();
                 if (now + ASYNC_TIMEOUT > lease) {
                     long newLease = now + 2 * ASYNC_TIMEOUT;
@@ -319,9 +324,8 @@ public class AsyncIndexUpdate implements
                     after, afterCheckpoint, afterTime);
 
             // the update succeeded, i.e. it no longer fails
-            if (failing) {
-                log.info("Index update {} no longer fails", name);
-                failing = false;
+            if (indexStats.isFailing()) {
+                indexStats.fixed();
             }
 
             // the update succeeded, so we can release the earlier checkpoint
@@ -332,15 +336,8 @@ public class AsyncIndexUpdate implements
             indexStats.setProcessedCheckpoint("");
             indexStats.releaseTempCheckpoint(afterCheckpoint);
 
-        } catch (CommitFailedException e) {
-            if (e == CONCURRENT_UPDATE) {
-                log.debug("Concurrent update detected in the {} index update", name);
-            } else if (failing) {
-                log.debug("The {} index update is still failing", name, e);
-            } else {
-                log.warn("The {} index update failed", name, e);
-                failing = true;
-            }
+        } catch (Exception e) {
+            indexStats.failed(e);
 
         } finally {
             if (checkpointToRelease != null) { // null during initial indexing
@@ -422,9 +419,9 @@ public class AsyncIndexUpdate implements
             String msg = "AsyncIndex ({}) update run completed in {}. Indexed {} nodes";
             //Log at info level if time taken is more than 5 min
             if (watch.elapsed(TimeUnit.MINUTES) >= 5) {
-                log.info(msg, name, watch, callback.updates);
+                log.info(msg, name, watch, indexStats.getUpdates());
             } else {
-                log.debug(msg, name, watch, callback.updates);
+                log.debug(msg, name, watch, indexStats.getUpdates());
             }
         }
 
@@ -499,6 +496,15 @@ public class AsyncIndexUpdate implements
         private final Stopwatch watch = Stopwatch.createUnstarted();
         private final ExecutionStats execStats = new ExecutionStats();
 
+        /** Flag to avoid repeatedly logging failure warnings */
+        private volatile boolean failing = false;
+        private long latestErrorWarn = 0;
+
+        private String failingSince = "";
+        private String latestError = null;
+        private String latestErrorTime = "";
+        private long consecutiveFailures = 0;
+
         public void start(String now) {
             status = STATUS_RUNNING;
             start = now;
@@ -521,6 +527,43 @@ public class AsyncIndexUpdate implements
             watch.reset();
         }
 
+        public void failed(Exception e) {
+            latestError = getStackTraceAsString(e);
+            latestErrorTime = now();
+            consecutiveFailures++;
+            if (!failing) {
+                // first occurrence of a failure
+                failing = true;
+                // reusing value so value display is consistent
+                failingSince = latestErrorTime;
+                latestErrorWarn = System.currentTimeMillis();
+                log.warn("[{}] The index update failed", name, e);
+            } else {
+                // subsequent occurrences
+                boolean warn = System.currentTimeMillis() - latestErrorWarn > ERROR_WARN_INTERVAL;
+                if (warn) {
+                    latestErrorWarn = System.currentTimeMillis();
+                    log.warn("[{}] The index update is still failing", name, e);
+                } else {
+                    log.debug("[{}] The index update is still failing", name, e);
+                }
+            }
+        }
+
+        public void fixed() {
+            log.info("[{}] Index update no longer fails", name);
+            failing = false;
+            failingSince = "";
+            consecutiveFailures = 0;
+            latestErrorWarn = 0;
+            latestError = null;
+            latestErrorTime = "";
+        }
+
+        public boolean isFailing() {
+            return failing;
+        }
+
         @Override
         public String getStart() {
             return start;
@@ -559,8 +602,13 @@ public class AsyncIndexUpdate implements
             return this.isPaused;
         }
 
-        void setUpdates(long updates) {
-            this.updates = updates;
+        void resetUpdates() {
+            this.updates = 0;
+        }
+
+        long incUpdates() {
+            updates++;
+            return updates;
         }
 
         @Override
@@ -610,6 +658,11 @@ public class AsyncIndexUpdate implements
         }
 
         @Override
+        public CompositeData getIndexedNodesCount() {
+            return execStats.getIndexedNodesCount();
+        }
+
+        @Override
         public CompositeData getConsolidatedExecutionStats() {
             return execStats.getConsolidatedStats();
         }
@@ -623,9 +676,12 @@ public class AsyncIndexUpdate implements
         public String toString() {
             return "AsyncIndexStats [start=" + start + ", done=" + done
                     + ", status=" + status + ", paused=" + isPaused
+                    + ", failing=" + failing + ", failingSince=" + failingSince
+                    + ", consecutiveFailures=" + consecutiveFailures
                     + ", updates=" + updates + ", referenceCheckpoint="
                     + referenceCp + ", processedCheckpoint=" + processedCp
-                    + " ,tempCheckpoints=" + tempCps + " ]";
+                    + " ,tempCheckpoints=" + tempCps + ", latestErrorTime="
+                    + latestErrorTime + ", latestError=" + latestError + " ]";
         }
 
         @Override
@@ -636,6 +692,7 @@ public class AsyncIndexUpdate implements
         private class ExecutionStats {
             private final TimeSeriesRecorder execCounter;
             private final TimeSeriesRecorder execTimer;
+            private final TimeSeriesRecorder indexedNodesCounter;
 
             /**
              * Captures consolidated execution stats since last reset
@@ -649,6 +706,7 @@ public class AsyncIndexUpdate implements
             private ExecutionStats() {
                 execCounter = new TimeSeriesRecorder(true);
                 execTimer = new TimeSeriesRecorder(true);
+                indexedNodesCounter = new TimeSeriesRecorder(true);
 
                 try {
                     consolidatedType = new CompositeType("ConsolidatedStats",
@@ -667,6 +725,7 @@ public class AsyncIndexUpdate implements
 
             private void recordExecution(long time, long updates) {
                 execTimer.getCounter().addAndGet(time);
+                indexedNodesCounter.getCounter().addAndGet(updates);
                 consolidatedExecTime.addAndGet(time);
                 consolidatedNodes.addAndGet(updates);
             }
@@ -679,6 +738,10 @@ public class AsyncIndexUpdate implements
                 return TimeSeriesStatsUtil.asCompositeData(execTimer, "ExecutionTime");
             }
 
+            private CompositeData getIndexedNodesCount() {
+                return TimeSeriesStatsUtil.asCompositeData(indexedNodesCounter, "ExecutionNodesCount");
+            }
+
             private CompositeData getConsolidatedStats() {
                 try {
                     Long[] values = new Long[]{consolidatedExecRuns.longValue(),
@@ -699,8 +762,29 @@ public class AsyncIndexUpdate implements
             private void recordTick() {
                 execCounter.recordOneSecond();
                 execTimer.recordOneSecond();
+                indexedNodesCounter.recordOneSecond();
             }
         }
+
+        @Override
+        public String getFailingSince() {
+            return failingSince;
+        }
+
+        @Override
+        public long getConsecutiveFailedExecutions() {
+            return consecutiveFailures;
+        }
+
+        @Override
+        public String getLatestError() {
+            return latestError;
+        }
+
+        @Override
+        public String getLatestErrorTime() {
+            return latestErrorTime;
+        }
     }
 
     /**
@@ -758,7 +842,7 @@ public class AsyncIndexUpdate implements
     }
 
     public boolean isFailing() {
-        return failing;
+        return indexStats.isFailing();
     }
 
 }

Modified: jackrabbit/oak/branches/1.2/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdateTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.2/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdateTest.java?rev=1710617&r1=1710616&r2=1710617&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.2/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdateTest.java (original)
+++ jackrabbit/oak/branches/1.2/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdateTest.java Mon Oct 26 15:10:29 2015
@@ -25,6 +25,8 @@ import static org.apache.jackrabbit.oak.
 import static org.apache.jackrabbit.oak.plugins.index.property.PropertyIndexEditorProvider.TYPE;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
@@ -33,17 +35,18 @@ import java.util.Collections;
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.Semaphore;
+import java.util.concurrent.TimeUnit;
 
 import javax.annotation.CheckForNull;
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import javax.management.openmbean.CompositeData;
 
-import ch.qos.logback.classic.Level;
 import org.apache.jackrabbit.oak.api.CommitFailedException;
 import org.apache.jackrabbit.oak.api.PropertyState;
 import org.apache.jackrabbit.oak.api.Type;
 import org.apache.jackrabbit.oak.commons.junit.LogCustomizer;
+import org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate.AsyncIndexStats;
 import org.apache.jackrabbit.oak.plugins.index.property.PropertyIndexEditorProvider;
 import org.apache.jackrabbit.oak.plugins.index.property.PropertyIndexLookup;
 import org.apache.jackrabbit.oak.plugins.memory.MemoryNodeStore;
@@ -59,6 +62,8 @@ import org.apache.jackrabbit.oak.spi.sta
 import org.apache.jackrabbit.oak.spi.state.NodeStore;
 import org.junit.Test;
 
+import ch.qos.logback.classic.Level;
+
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
@@ -557,6 +562,25 @@ public class AsyncIndexUpdateTest {
                 provider.isFailed());
         assertTrue("Expecting no checkpoints",
                 store.listCheckpoints().size() == 0);
+
+        // OAK-3054 failure reports
+        AsyncIndexStats stats = async.getIndexStats();
+        String since = stats.getFailingSince();
+        assertTrue(stats.isFailing());
+        assertEquals(1, stats.getConsecutiveFailedExecutions());
+        assertEquals(since, stats.getLatestErrorTime());
+
+        TimeUnit.MILLISECONDS.sleep(100);
+        async.run();
+        assertTrue(stats.isFailing());
+        assertEquals(2, stats.getConsecutiveFailedExecutions());
+        assertEquals(since, stats.getFailingSince());
+        assertNotEquals(since, stats.getLatestErrorTime());
+
+        stats.fixed();
+        assertFalse(stats.isFailing());
+        assertEquals(0, stats.getConsecutiveFailedExecutions());
+        assertEquals("", stats.getFailingSince());
     }
 
     /**