You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/10/24 13:41:41 UTC
[GitHub] zeppelin pull request #2630: [HOTFIX] fix build spark and R interpreters
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2630
[HOTFIX] fix build spark and R interpreters
### What is this PR for?
Fix build interpreters (apark and R) which broken after https://github.com/apache/zeppelin/pull/2592 and
https://github.com/apache/zeppelin/pull/2596
### What type of PR is it?
[Hot Fix]
### How should this be tested?
build interpreters
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin fix_r_interpretator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2630
----
commit 0c9828bb9beb0f366af3d1a9eadd8d4b064213b7
Author: tinkoff-dwh <ti...@gmail.com>
Date: 2017-10-24T13:30:58Z
[HOTFIX] fix build spark and R interpreters
----
---
[GitHub] zeppelin pull request #2630: [HOTFIX] fix build spark and R interpreters
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2630
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Yes, I know the current situation and this PR solves what kind of problem, but our merge script uses squash merge from PR branch and it means if that PR branch has `property` in that branch, it would have been merged by our merge script, otherwise if that PR branch doesn't have `property` in that branch, CI would fail. But AFAIK, that branch doesn't have `property` but CI passed. I just wanted to know how it happens.
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
I’m also curious about it. It’s very basic error when compiling without symbol.
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2630
@necosta @zjffdu @felixcheung
pls help with review
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
LGTM. I'll merge it as a hotfix. BTW, I think it would be better to divide two different PR by fixing bug and refactoring somethings.
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Ok thanks for fixing this.
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2630
@jongyoul
this branch has no conflicts with branch master. In CI all ok, because branch of PR has field property. After merge jobs falls (CI, branch master) https://travis-ci.org/apache/zeppelin/builds/291922211?utm_source=github_status&utm_medium=notification
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2630
@jongyoul @zjffdu
after merge https://github.com/apache/zeppelin/pull/2596
https://github.com/apache/zeppelin/pull/2596/files#diff-dbda0c4083ad9c59ff05f0273b5e760fR935
`property.getProperty...`
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Yes, what I wondered is how that PR passed our CI. `property` doesn't exist in the class and it shouldn't have passed CI. May we have a hole on our CI?
---
[GitHub] zeppelin issue #2630: [HOTFIX] fix build spark and R interpreters
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Thanks @tinkoff-dwh for fixing this. Could you let me know how SparkRInterpreter is broken, I am curious to know why our CI didn't catch this.
---