[jira] [Comment Edited] (KAFKA-10493) Ktable out-of-order updates are not being ignored

["Matthias J. Sax (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198661#comment-17198661 ] 

Matthias J. Sax edited comment on KAFKA-10493 at 9/19/20, 5:48 AM:
-------------------------------------------------------------------

Maybe [~vvcephei] can shed some light? It's fairly new code and I am actually not 100% sure atm.
{quote}Maybe a configuration parameter in Materialized could be this opt-in. If you think it makes sense I can try to create a PR.
{quote}
IIRC, we discussed this on the original KIP but discarded the idea for now. However, we are facing a couple of other issue (cf. KIP-300) that might require us to rework some APIs. For this case, we could potentially just change the semantics without a config.

Also, the idea of the WARN log was (IIRC), to maybe do a "breaking" change in 3.0 and just change the semantics.


was (Author: mjsax):
Maybe [~vvcephei] can shed some light? It's fairly new code and I am actually not 100% sure atm.

> Ktable out-of-order updates are not being ignored
> -------------------------------------------------
>
>                 Key: KAFKA-10493
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10493
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 2.6.0
>            Reporter: Pedro Gontijo
>            Priority: Major
>         Attachments: KTableOutOfOrderBug.java
>
>
> On a materialized KTable, out-of-order records for a given key (records which timestamp are older than the current value in store) are not being ignored but used to update the local store value and also being forwarded.
> I believe the bug is here: [https://github.com/apache/kafka/blob/2.6.0/streams/src/main/java/org/apache/kafka/streams/state/internals/ValueAndTimestampSerializer.java#L77] It should return true, not false (see javadoc)
> The bug impacts here: [https://github.com/apache/kafka/blob/2.6.0/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableSource.java#L142-L148]
> I have attached a simple stream app that shows the issue happening.
> Thank you!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)