You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/03/14 22:59:51 UTC
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/552
Riak Linux - fix
- Move the utility methods to the appropriate
BashCommands class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn riak-packagecloud
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/552.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #552
----
commit bddb4311c3c1892b2ef2a64bb55e618e9be030d7
Author: Valentin Aitken <bo...@gmail.com>
Date: 2015-03-14T21:58:38Z
Riak Linux
- Move the utility methods to the appropriate
BashCommands class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/552#discussion_r26489304
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
@@ -190,45 +190,14 @@ public void install() {
private ImmutableList<String> installDebianBased() {
return ImmutableList.<String>builder()
.add("curl https://packagecloud.io/install/repositories/basho/riak/script.deb | " + BashCommands.sudo("bash"))
- .add(BashCommands.sudo("apt-get install --assume-yes riak"))
+ .add(BashCommands.sudo("apt-get install --assume-yes riak=" + getEntity().getFullVersion() + "-1"))
--- End diff --
This is how packagecloud works https://packagecloud.io/basho/riak/packages/ubuntu/precise/riak_2.0.5-1_amd64.deb
https://packagecloud.io/basho/riak/packages/el/5/riak-2.0.5-1.x86_64.rpm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/552#issuecomment-81689423
looks good. i've some concerns whether the new `BashCommands` do the right thing in all situations (e.g. if you give a list of commands, but then it is run as a single CLI rather than a script) but that applies to others as well, it can be cleaned up as needed. (in general i'd like to move away from them in any case, to pure yaml.)
minor comment about `=` and `-1` in the filename to be installed. confirm that's correct and/or add comment and then happy to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/552#issuecomment-81707478
I tested it and it is ok.
-1 is part of the version and it is included when you specify the version in packagecloud. However it seems that it is not exactly part of the version since the package name could end with 2.0.5-OSX http://docs.basho.com/riak/latest/downloads/ .
So to ease my work I wrote it that way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/552#discussion_r26486437
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
@@ -190,45 +190,14 @@ public void install() {
private ImmutableList<String> installDebianBased() {
return ImmutableList.<String>builder()
.add("curl https://packagecloud.io/install/repositories/basho/riak/script.deb | " + BashCommands.sudo("bash"))
- .add(BashCommands.sudo("apt-get install --assume-yes riak"))
+ .add(BashCommands.sudo("apt-get install --assume-yes riak=" + getEntity().getFullVersion() + "-1"))
--- End diff --
why the `-1` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Riak Linux - fix
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/552#discussion_r26486618
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
@@ -190,45 +190,14 @@ public void install() {
private ImmutableList<String> installDebianBased() {
return ImmutableList.<String>builder()
.add("curl https://packagecloud.io/install/repositories/basho/riak/script.deb | " + BashCommands.sudo("bash"))
- .add(BashCommands.sudo("apt-get install --assume-yes riak"))
+ .add(BashCommands.sudo("apt-get install --assume-yes riak=" + getEntity().getFullVersion() + "-1"))
--- End diff --
and should it really be `riak=` not `riak-` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---