You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Peter Varga via Review Board <no...@reviews.apache.org> on 2020/05/20 16:00:20 UTC
Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72532/
-----------------------------------------------------------
Review request for hive, Karen Coppage and Peter Vary.
Repository: hive-git
Description
-------
since HIVE-21225 there are two redundant implementation of the AcidUtils.getAcidState.
The previous implementation (without the recursive listing) can be removed.
Also the performance can be improved, by removing unnecessary fileStatus calls.
Diffs
-----
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 569de706df
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java 86f762e97c
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 270c5909fc
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java ca234cfb37
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 1059cb227f
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java 16c915959c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java 598220b0c4
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 5fa3d9ad42
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 05ea38c5af
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java fa2ede3738
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 4d0e5f703e
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java 724a4375b7
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java 1cd95f8015
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java a96cf1e731
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java 366282a30f
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 9e6d47ebc5
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 12a15a16eb
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java f63c40a7b5
streaming/src/test/org/apache/hive/streaming/TestStreaming.java 6101caac66
Diff: https://reviews.apache.org/r/72532/diff/1/
Testing
-------
Thanks,
Peter Varga
Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup
Posted by Peter Varga via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72532/
-----------------------------------------------------------
(Updated May 21, 2020, 1:23 p.m.)
Review request for hive, Karen Coppage and Peter Vary.
Repository: hive-git
Description
-------
since HIVE-21225 there are two redundant implementation of the AcidUtils.getAcidState.
The previous implementation (without the recursive listing) can be removed.
Also the performance can be improved, by removing unnecessary fileStatus calls.
Diffs (updated)
-----
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 569de706df
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java 86f762e97c
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java bf332bc0b8
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java ca234cfb37
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 1059cb227f
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java 16c915959c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java 598220b0c4
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 5fa3d9ad42
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 018c73376f
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java fa2ede3738
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java d83a50f555
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java 5e11d8d2d8
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java 1bdec7df2d
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java a96cf1e731
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java 366282a30f
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 9e6d47ebc5
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 12a15a16eb
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java f63c40a7b5
streaming/src/test/org/apache/hive/streaming/TestStreaming.java 6101caac66
Diff: https://reviews.apache.org/r/72532/diff/2/
Changes: https://reviews.apache.org/r/72532/diff/1-2/
Testing
-------
Thanks,
Peter Varga