[GitHub] [logging-log4j2] remkop commented on issue #275: Log4 j2 2621

[GitBox <gi...@apache.org>]

remkop commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500671754
 
 
   I took a look. Many files changed but vast majority is import changes.
   
   Files of interest:
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java (118)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginAttributeVisitor.java (27)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginBuilderAttributeVisitor.java (26)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginConfigurationVisitor.java (10)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginElementVisitor.java (18)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginNodeVisitor.java (13)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginValueVisitor.java (17)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/osgi/BundleContextSelector.java (77)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/selector/BasicContextSelector.java (11)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/selector/ClassLoaderContextSelector.java (47)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/selector/ContextSelector.java (31)
   M log4j-core/src/main/java/org/apache/logging/log4j/core/selector/JndiContextSelector.java (36)
   
   Overall I could not spot any issues but to be honest I did not look at the context selector stuff in much detail.
   
   I could not find in the diff the place where the Java file for recording plugins is emitted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services