You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2024/01/29 07:39:07 UTC

[PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

morrySnow opened a new pull request, #30501:
URL: https://github.com/apache/doris/pull/30501

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914174945

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.45 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit b203c54f4b319404b50be429e0b42ae925063d06, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.07	0.02	0.03
   query3	0.22	0.06	0.06
   query4	1.65	0.09	0.10
   query5	0.52	0.51	0.50
   query6	1.18	0.63	0.62
   query7	0.02	0.02	0.01
   query8	0.03	0.02	0.03
   query9	0.57	0.49	0.48
   query10	0.55	0.56	0.55
   query11	0.12	0.08	0.08
   query12	0.11	0.09	0.10
   query13	0.61	0.61	0.60
   query14	0.78	0.81	0.79
   query15	0.79	0.78	0.77
   query16	0.38	0.39	0.38
   query17	1.02	0.97	0.98
   query18	0.23	0.23	0.26
   query19	1.84	1.76	1.83
   query20	0.01	0.00	0.01
   query21	15.43	0.59	0.58
   query22	2.67	2.57	2.32
   query23	17.19	0.77	0.85
   query24	2.65	1.08	1.11
   query25	0.38	0.11	0.15
   query26	0.54	0.14	0.14
   query27	0.06	0.06	0.04
   query28	11.35	0.90	0.83
   query29	12.53	3.13	3.10
   query30	0.64	0.53	0.53
   query31	2.79	0.35	0.36
   query32	3.31	0.47	0.49
   query33	3.22	3.20	3.21
   query34	15.73	4.30	4.22
   query35	4.29	4.35	4.41
   query36	1.13	1.08	1.06
   query37	0.08	0.05	0.05
   query38	0.04	0.03	0.03
   query39	0.03	0.02	0.01
   query40	0.16	0.12	0.13
   query41	0.08	0.01	0.01
   query42	0.02	0.02	0.01
   query43	0.03	0.02	0.02
   Total cold run time: 105.09 s
   Total hot run time: 31.45 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914150601

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37733 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit b203c54f4b319404b50be429e0b42ae925063d06, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17597	4905	5039	4905
   q2	2039	143	133	133
   q3	10599	945	945	945
   q4	5756	778	854	778
   q5	7761	2809	2920	2809
   q6	195	124	128	124
   q7	1160	756	722	722
   q8	9408	2068	2049	2049
   q9	7602	6526	6379	6379
   q10	8074	2409	2413	2409
   q11	406	213	198	198
   q12	739	269	295	269
   q13	18001	3307	3303	3303
   q14	282	245	259	245
   q15	534	502	489	489
   q16	488	392	421	392
   q17	949	517	496	496
   q18	7120	6091	6108	6091
   q19	1580	1479	1373	1373
   q20	645	332	337	332
   q21	7073	3112	3008	3008
   q22	799	320	284	284
   Total cold run time: 108807 ms
   Total hot run time: 37733 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5149	4939	4919	4919
   q2	331	243	227	227
   q3	2979	2706	2725	2706
   q4	1758	1593	1525	1525
   q5	5335	5149	5107	5107
   q6	207	118	113	113
   q7	2197	1758	1738	1738
   q8	3086	3194	3279	3194
   q9	8588	8623	15069	8623
   q10	5538	3401	3497	3401
   q11	555	492	460	460
   q12	740	612	617	612
   q13	16982	3102	3058	3058
   q14	280	250	261	250
   q15	532	492	493	492
   q16	516	448	480	448
   q17	1872	1682	1721	1682
   q18	8720	15510	8739	8739
   q19	27709	1594	1596	1594
   q20	4618	1898	1879	1879
   q21	15648	4864	4772	4772
   q22	1248	499	475	475
   Total cold run time: 114588 ms
   Total hot run time: 56014 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914124291

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #30501:
URL: https://github.com/apache/doris/pull/30501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914166979

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172198 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit b203c54f4b319404b50be429e0b42ae925063d06, data reload: false
   
   query1	935	326	322	322
   query2	6617	1894	1759	1759
   query3	6705	200	193	193
   query4	36043	21920	21968	21920
   query5	4461	358	414	358
   query6	238	151	148	148
   query7	4603	255	254	254
   query8	247	166	186	166
   query9	8629	2263	2246	2246
   query10	419	205	198	198
   query11	17741	15312	15209	15209
   query12	119	67	67	67
   query13	1672	372	366	366
   query14	9218	6317	6439	6317
   query15	208	175	181	175
   query16	5704	250	257	250
   query17	950	474	458	458
   query18	1801	253	246	246
   query19	178	138	133	133
   query20	66	75	64	64
   query21	196	142	127	127
   query22	4808	4682	4706	4682
   query23	30969	30370	30255	30255
   query24	11654	2764	2765	2764
   query25	593	308	303	303
   query26	1796	132	133	132
   query27	3209	280	290	280
   query28	7500	1841	1832	1832
   query29	1851	621	606	606
   query30	281	137	140	137
   query31	905	706	708	706
   query32	77	51	55	51
   query33	684	204	219	204
   query34	1147	460	464	460
   query35	871	771	752	752
   query36	1297	1199	1198	1198
   query37	93	58	58	58
   query38	3249	3115	3108	3108
   query39	1308	1242	1240	1240
   query40	200	86	85	85
   query41	38	36	35	35
   query42	82	80	81	80
   query43	518	474	495	474
   query44	1080	687	700	687
   query45	193	175	173	173
   query46	1056	645	640	640
   query47	1548	1523	1571	1523
   query48	389	293	300	293
   query49	1129	285	277	277
   query50	678	318	305	305
   query51	5259	5115	5151	5115
   query52	89	78	77	77
   query53	314	256	260	256
   query54	247	178	188	178
   query55	85	71	73	71
   query56	174	160	159	159
   query57	970	906	892	892
   query58	186	152	155	152
   query59	2552	2587	2570	2570
   query60	197	174	173	173
   query61	87	81	80	80
   query62	620	361	347	347
   query63	275	255	266	255
   query64	4936	1743	1722	1722
   query65	3269	3207	3193	3193
   query66	1262	334	311	311
   query67	14339	14147	14186	14147
   query68	3810	489	487	487
   query69	433	298	298	298
   query70	1463	1496	1487	1487
   query71	263	221	209	209
   query72	3723	2807	2840	2807
   query73	691	312	312	312
   query74	6654	6277	6304	6277
   query75	2805	2270	2312	2270
   query76	2657	984	1012	984
   query77	361	228	222	222
   query78	9096	8816	8515	8515
   query79	2640	483	491	483
   query80	1929	317	313	313
   query81	537	196	208	196
   query82	699	77	80	77
   query83	234	117	114	114
   query84	286	79	72	72
   query85	2171	324	309	309
   query86	513	359	363	359
   query87	3469	3258	3208	3208
   query88	3573	2181	2161	2161
   query89	413	357	354	354
   query90	1861	182	185	182
   query91	147	112	116	112
   query92	53	43	43	43
   query93	2290	450	413	413
   query94	1358	160	159	159
   query95	506	458	448	448
   query96	615	320	308	308
   query97	4299	4141	4151	4141
   query98	208	195	181	181
   query99	1028	683	690	683
   Total cold run time: 281599 ms
   Total hot run time: 172198 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914388066

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914388132

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) should not generate same exprId for diff column when sink [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30501:
URL: https://github.com/apache/doris/pull/30501#issuecomment-1914179060

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit b203c54f4b319404b50be429e0b42ae925063d06 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.2 seconds inserted 10000000 Rows, about 757K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org