You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/07 06:57:13 UTC

[GitHub] [apisix] mikechengwei commented on a diff in pull request #8254: test: merge extra_init_by_lua_start and extra_init_by_lua directive in test cases.

mikechengwei commented on code in PR #8254:
URL: https://github.com/apache/apisix/pull/8254#discussion_r1015057503


##########
t/APISIX.pm:
##########
@@ -495,8 +495,6 @@ _EOC_
 
     # The new directive is introduced here to modify the schema
     # before apisix validate in require("apisix")
-    # Todo: merge extra_init_by_lua_start and extra_init_by_lua

Review Comment:
   Do you mean the `extra_init_by_lua` function should include the extra_init_by_lua_start module?
   This commit is my one attempt.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org