You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by an...@apache.org on 2011/11/03 15:45:26 UTC
svn commit: r1197162 - in
/tuscany/sca-java-2.x/trunk/modules/binding-jms/src:
main/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessor.java
test/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessorWriteTestCase.java
Author: antelder
Date: Thu Nov 3 14:45:25 2011
New Revision: 1197162
URL: http://svn.apache.org/viewvc?rev=1197162&view=rev
Log:
TUSCANY-3972 JMSBIndingProcessor.writeDestinationProperties should handle Destination Type
Modified:
tuscany/sca-java-2.x/trunk/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessor.java
tuscany/sca-java-2.x/trunk/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessorWriteTestCase.java
Modified: tuscany/sca-java-2.x/trunk/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessor.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessor.java?rev=1197162&r1=1197161&r2=1197162&view=diff
==============================================================================
--- tuscany/sca-java-2.x/trunk/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessor.java (original)
+++ tuscany/sca-java-2.x/trunk/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessor.java Thu Nov 3 14:45:25 2011
@@ -1421,11 +1421,10 @@ public class JMSBindingProcessor extends
writer.writeAttribute("jndiName", destinationName);
}
- // Type not handled yet
- // String destinationType = jmsBinding.getDestinationType();
- // if ( destinationType != null && destinationType.length() > 0) {
- // writer.writeAttribute("type", destinationType);
- // }
+ String destinationType = jmsBinding.getDestinationType();
+ if ( destinationType != null && destinationType.length() > 0) {
+ writer.writeAttribute("type", destinationType);
+ }
String destinationCreate = jmsBinding.getDestinationCreate();
if ( destinationCreate != null && destinationCreate.length() > 0 &&
Modified: tuscany/sca-java-2.x/trunk/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessorWriteTestCase.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessorWriteTestCase.java?rev=1197162&r1=1197161&r2=1197162&view=diff
==============================================================================
--- tuscany/sca-java-2.x/trunk/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessorWriteTestCase.java (original)
+++ tuscany/sca-java-2.x/trunk/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSBindingProcessorWriteTestCase.java Thu Nov 3 14:45:25 2011
@@ -404,7 +404,7 @@ public class JMSBindingProcessorWriteTes
"<component name=\"HelloWorldComponent\">" +
"<service name=\"HelloWorldService\">" +
"<binding.jms><operationProperties name=\"JKL\" /> " +
- "<destination jndiName=\"AAA\">" +
+ "<destination jndiName=\"AAA\" type=\"queue\">" +
"<property name=\"AAAProp\" type=\"string\"></property>" +
"</destination> " +
"<connectionFactory jndiName=\"ABC\" /> "+