[GitHub] timbru31 commented on a change in pull request #267: CB-12941: update typings

[GitBox <gi...@apache.org>]

timbru31 commented on a change in pull request #267: CB-12941: update typings
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/267#discussion_r218465706
 
 

 ##########
 File path: types/index.d.ts
 ##########
 @@ -1,39 +1,14 @@
-// Type definitions for Apache Cordova InAppBrowser plugin
+// Type definitions for Apache Cordova InAppBrowser plugin 3.0
 // Project: https://github.com/apache/cordova-plugin-inappbrowser
 // Definitions by: Microsoft Open Technologies Inc <http://msopentech.com>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// 
+//
 // Copyright (c) Microsoft Open Technologies Inc
 // Licensed under the MIT license.
+// TypeScript Version: 2.3
+type channel = "loadstart" | "loadstop" | "loaderror" | "exit";
 
 interface Window {
-    /**
-     * Opens a URL in a new InAppBrowser instance, the current browser instance, or the system browser.
 
 Review comment:
   Below is a generic open method (`     open(url: string, target?: string, options?: string, replace?: boolean): InAppBrowser;
   `) - this is just redundant when you have typings like target could be `"_self" | "_blank" | "_system" | string`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org