You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/11/15 10:58:39 UTC
[GitHub] [incubator-brpc] 372046933 opened a new issue, #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
372046933 opened a new issue, #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995
**Describe the bug (描述bug)**
`IOBuf` cannot `append_user_data` with address starts after `RegisterMemoryForRdma`
```bash
W20221115 18:15:32.455838 79345 rdma_endpoint.cpp:727] Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
W20221115 18:15:32.455842 79345 socket.cpp:1705] Fail to keep-write into Socket{id=2 fd=1034 addr=0.0.0.0:8002:53496} (0x55b33af574d0): Unknown error 3002 [3002]
E20221115 18:15:32.455933 79247 server2.cpp:95] RPC call failed: [E3002]Fail to keep-write into Socket{id=2 fd=1034 addr=0.0.0.0:8002:53496} (0x0x55b33af574d0): Memory not registered for RDMA
```
**To Reproduce (复现方法)**
```c++
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
#include <gflags/gflags.h>
#include "butil/atomicops.h"
#include "butil/logging.h"
#include "butil/time.h"
#include "brpc/channel.h"
#include "brpc/rdma/rdma_helper.h"
#include "brpc/server.h"
#include "bvar/variable.h"
#include "test.pb.h"
DEFINE_int32(port, 8002, "TCP Port of this server");
DEFINE_bool(use_rdma, true, "Use RDMA or not");
namespace brpc{
namespace rdma {
DECLARE_bool(rdma_trace_verbose);
}
} // namespace brpc
butil::atomic<uint64_t> g_last_time(0);
namespace test {
class PerfTestServiceImpl : public PerfTestService {
public:
PerfTestServiceImpl() {}
~PerfTestServiceImpl() {};
void Test(google::protobuf::RpcController* cntl_base,
const PerfTestRequest* request,
PerfTestResponse* response,
google::protobuf::Closure* done) {
brpc::ClosureGuard done_guard(done);
uint64_t last = g_last_time.load(butil::memory_order_relaxed);
uint64_t now = butil::monotonic_time_us();
if (now > last && now - last > 100000) {
if (g_last_time.exchange(now, butil::memory_order_relaxed) == last) {
response->set_cpu_usage(bvar::Variable::describe_exposed("process_cpu_usage"));
} else {
response->set_cpu_usage("");
}
} else {
response->set_cpu_usage("");
}
brpc::Controller* cntl = static_cast<brpc::Controller*>(cntl_base);
if (request->echo_attachment()) {
cntl->response_attachment().append(cntl->request_attachment());
}
if (!cntl->request_attachment().empty()) {
std::string tmp;
cntl->request_attachment().cutn(&tmp, 5);
LOG(INFO) << tmp;
}
}
};
}
void run_client() {
brpc::rdma::GlobalRdmaInitializeOrDie();
brpc::ChannelOptions options;
options.use_rdma = FLAGS_use_rdma;
options.protocol = "baidu_std";
options.connection_type = "single";
options.timeout_ms = 10000;
options.max_retry = 0;
std::string server = "0.0.0.0:8002";
brpc::Channel* _channel = new brpc::Channel();
if (_channel->Init(server.c_str(), &options) != 0) {
LOG(ERROR) << "Fail to initialize channel";
return;
}
brpc::Controller cntl;
test::PerfTestResponse response;
test::PerfTestRequest request;
char buffer[16] = {'a', 'b', 'c'};
brpc::rdma::RegisterMemoryForRdma(buffer, 16);
cntl.request_attachment().append_user_data(buffer + 1, 3, [](void*) {});
request.set_echo_attachment(false);
test::PerfTestService_Stub stub(_channel);
stub.Test(&cntl, &request, &response, NULL);
if (cntl.Failed()) {
LOG(ERROR) << "RPC call failed: " << cntl.ErrorText();
} else {
LOG(INFO) << "RPC call success";
}
}
int main(int argc, char* argv[]) {
brpc::rdma::fLB::FLAGS_rdma_trace_verbose = true;
GFLAGS_NS::ParseCommandLineFlags(&argc, &argv, true);
if (FLAGS_use_rdma) {
LOG(INFO) << "Call GlobalRdmaInitializeOrDie";
brpc::rdma::GlobalRdmaInitializeOrDie();
}
brpc::Server server;
test::PerfTestServiceImpl perf_test_service_impl;
if (server.AddService(&perf_test_service_impl,
brpc::SERVER_DOESNT_OWN_SERVICE) != 0) {
LOG(ERROR) << "Fail to add service";
return -1;
}
g_last_time.store(0, butil::memory_order_relaxed);
brpc::ServerOptions options;
options.use_rdma = FLAGS_use_rdma;
if (server.Start(FLAGS_port, &options) != 0) {
LOG(ERROR) << "Fail to start EchoServer";
return -1;
}
run_client();
server.RunUntilAskedToQuit();
return 0;
}
```
**Expected behavior (期望行为)**
`IOBuf` can `append_user_data` with data in `RegisterMemoryForRdma`
**Versions (各种版本)**
OS: Ubuntu 22.04
Compiler: GCC 11.2.0
brpc: 3d90221107000133c2d7f3ccc6372680fb6af27d
protobuf:
**Additional context/screenshots (更多上下文/截图)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1319777273
Maybe another interface `append_user_data_ib` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1323723025
> If `IOBuf::append_user_data` with size 0. Could we do early return here?
That's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1318280013
Yes, we can manage `LKey`. Does adding parameter to `append_user_data ` breaks backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1318112797
In my scenario, memory pool is not applicable, because the memory are allocated by allocator in the library out of control. I have tested `RegisterMemoryForRdma` with size from `KB`s to `MB`s and found that `RegisterMemoryForRdma` always faster than `memcpy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1325850024
@372046933 Thanks for your feedback. About the return value problem, maybe @wwbmmm can share your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1318291576
> Yes, we can manage `LKey`. Does adding parameter to `append_user_data ` breaks backward compatibility?
Yes. Must try to keep the ABI compatibility. But I think it is a better way to solve this problem. Because application has more information than brpc so that the overall efficiency will be higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1316161463
@Tuvie How much work is needed? It's grateful if you can shed some light on the relation between `user_data` and memory registered by `ibv_reg_mr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1315211157
Thanks. This is a bug. The buf to attach is not the exactly same with the base address registered. I will commit a patch to fix this bug later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1321032110
@372046933 Pls try this PR: https://github.com/apache/incubator-brpc/pull/2005
A new function named append_user_data_with_meta is provided. You should give the lkey returned by RegisterMemoryForRdma as the meta. Pls note that now RegisterMemoryForRdma returns 0 when failed, just contrast to the previous code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1317996849
Since linear scan is not efficient. Would interval tree be used to query and update in $\mathcal{O}(\log{}n)$ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm closed issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
wwbmmm closed issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
URL: https://github.com/apache/incubator-brpc/issues/1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1318211889
> Since linear scan is not efficient. Would interval tree be used to query and update in O(logn) ?
Currently, it is a tradeoff to avoid using lock for lkey lookup (more frequent operation during data transmission). To design a better solution, here is a question for your scenario: how do you use append_user_data in you application? Since you don't manage memory by yourself, why don't you use IOBuf instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1318247334
@Tuvie We use `append_user_data` in tensorflow's `AsyncOpKernel::ComputeAsync`. The memory comes from tensor in TensorFlow OP. It's allocated by the framework on each run.
We could use `IOBuf::append`, but `append` introduces an extra copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1317186330
> @Tuvie How much work is needed? It's grateful if you can shed some light on the relation between `user_data` and memory registered by `ibv_reg_mr`
A PR is committed: https://github.com/apache/incubator-brpc/pull/1999
Pls try again and refer to the update on docs.
By default, if you use memory managed by IOBuf, you don't need to register memory by yourself. If you manage memory outside the IOBuf, you should register memory explicitly as you did. However, since it is not efficient to lookup the lkey for this kind of user_data, we suggest you maintain your own memory pool and register all the pool once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1325848850
@Tuvie I have tested `append_user_data_with_meta`. It works as expected. As for the return value of `append_user_data` when size is 0. I added a pre-check in application and skip the call when size equals 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1317959593
Would it be better if `MAX_USER_MRS` be defined by `gflags`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1318269408
> @Tuvie We use `append_user_data` in tensorflow's `AsyncOpKernel::ComputeAsync`. The memory comes from tensor in TensorFlow OP. It's allocated by the framework on each run. We could use `IOBuf::append`, but `append` introduces an extra copy.
So what do you think if we add a new parameter for append_user_data function to specify the lkey directly? In this case we don't need to lookup the lkey in an inefficient way. But you have to manage the lkey as a corresponding buffer id by yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] Tuvie commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
Tuvie commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1321491547
> Thanks a million. Is `append_user_data_with_meta` in the PR? I couldn't find the definition in [40a24ab](https://github.com/apache/incubator-brpc/commit/40a24ab3b5f440d11bfb09c8afb2bc6300157688)
sorry, I repush the PR. Pls try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1323534641
@Tuvie
If `IOBuf::append_user_data` with size 0. Could we do early return here?
https://github.com/apache/incubator-brpc/blob/4308819cc4cf52fa52027ab9b10a2dbcaa84d3c4/src/butil/iobuf.cpp#L1209-L1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] 372046933 commented on issue #1995: Memory not registered for rdma. Is this iobuf allocated before calling GlobalRdmaInitializeOrDie? Or just forget to call RegisterMemoryForRdma for your own buffer?
Posted by GitBox <gi...@apache.org>.
372046933 commented on issue #1995:
URL: https://github.com/apache/incubator-brpc/issues/1995#issuecomment-1321077817
Thanks a million. Is `append_user_data_with_meta` in the PR? I couldn't find the definition in https://github.com/apache/incubator-brpc/pull/2005/commits/40a24ab3b5f440d11bfb09c8afb2bc6300157688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org