[jira] [Commented] (NETBEANS-126) Browser icons needs to be re-instated

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NETBEANS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283969#comment-16283969 ] 

ASF GitHub Bot commented on NETBEANS-126:
-----------------------------------------

matthiasblaesing closed pull request #251: [NETBEANS-126] Re-instate browser icons
URL: https://github.com/apache/incubator-netbeans/pull/251
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20-disabled.png b/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20-disabled.png
index d6168216e..c9436b4bc 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20-disabled.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20-disabled.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20.png b/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20.png
index d6168216e..31be03b59 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/chrome20.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20-disabled.png b/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20-disabled.png
index d6168216e..be2b1602e 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20-disabled.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20-disabled.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20.png b/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20.png
index d6168216e..6a35064fb 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/firefox20.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/ie20-disabled.png b/css.editor/src/org/netbeans/modules/css/resources/icons/ie20-disabled.png
index d6168216e..a09302316 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/ie20-disabled.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/ie20-disabled.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/ie20.png b/css.editor/src/org/netbeans/modules/css/resources/icons/ie20.png
index d6168216e..fcf1e7ce9 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/ie20.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/ie20.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/opera20-disabled.png b/css.editor/src/org/netbeans/modules/css/resources/icons/opera20-disabled.png
index d6168216e..bcd6d5cc2 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/opera20-disabled.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/opera20-disabled.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/opera20.png b/css.editor/src/org/netbeans/modules/css/resources/icons/opera20.png
index d6168216e..d68e4aa2b 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/opera20.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/opera20.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/safari20-disabled.png b/css.editor/src/org/netbeans/modules/css/resources/icons/safari20-disabled.png
index d6168216e..76b365341 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/safari20-disabled.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/safari20-disabled.png differ
diff --git a/css.editor/src/org/netbeans/modules/css/resources/icons/safari20.png b/css.editor/src/org/netbeans/modules/css/resources/icons/safari20.png
index d6168216e..3bbf54ba7 100644
Binary files a/css.editor/src/org/netbeans/modules/css/resources/icons/safari20.png and b/css.editor/src/org/netbeans/modules/css/resources/icons/safari20.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_16x.png
index 52855d9a8..87444445b 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_24x.png
index 297379dfe..8d6c8b51c 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chrome_24x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_16x.png
index 52855d9a8..e80d43d15 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_24x.png
index 297379dfe..7e4427120 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_chromium_24x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_16x.png
index 52855d9a8..3c896b745 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_24x.png
index 297379dfe..f4f9a403d 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_edge_24x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_16x.png
index 52855d9a8..2b830cc7e 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_24x.png
index 297379dfe..7e99d4d73 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_firefox_24x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_16x.png
index 52855d9a8..36fe800ce 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_24x.png
index 297379dfe..4f5d51d91 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_ie_24x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_16x.png
index 52855d9a8..9d6281e16 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_24x.png
index 297379dfe..99bb9adba 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_opera_24x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_16x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_16x.png
index 52855d9a8..f520cb34b 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_16x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_16x.png differ
diff --git a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_24x.png b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_24x.png
index 297379dfe..551ac1f40 100644
Binary files a/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_24x.png and b/web.browser.api/src/org/netbeans/modules/web/browser/ui/resources/browser_safari_24x.png differ


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Browser icons needs to be re-instated
> -------------------------------------
>
>                 Key: NETBEANS-126
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-126
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: lbruun
>            Assignee: lbruun
>            Priority: Minor
>              Labels: donation-fixes, pull-request-available
>         Attachments: css-editor-icons-usage.png, css-editor-icons.png, nb-icon.png, web-browser-api-icons.png
>
>
> A number of browser icons were "removed" from the donation, in [this changeset|http://hg.netbeans.org/releases/rev/034a0c65c347?revcount=1500]. They weren't actually removed, rather they were all replaced with a dummy NetBeans icon. I think Oracle removed them because Oracle couldn't donate such icons, as they don't "own" these trademarks.
> h2. Module path "css.editor"
> Removed from {{css.editor}}:
> !css-editor-icons.png!
> The browser icons in this module are - as far as I can tell - only used for code completion hints on CSS where they are used to signal if the browser has support for the CSS property or not. Example:
> !css-editor-icons-usage.png!
> h2. Module path "web.browser.api"
> Removed from {{web.browser.api}}:
> !web-browser-api-icons.png!
> The above icons are all replaced in the donation with a dummy NetBeans icon: !nb-icon.png! 
> I'll do a PR to re-instate these.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)