You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Tom Hobbs (JIRA)" <ji...@apache.org> on 2009/03/17 14:22:50 UTC

[jira] Updated: (RIVER-301) Move the tests into the JUnit framework inside the main source project

     [ https://issues.apache.org/jira/browse/RIVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Hobbs updated RIVER-301:
----------------------------

    Attachment: integrationtest.xml

This is the new file.

(Sorry, the "create patch" option seems to have fallen off my IDE and it was late when I tried to get it done last night and that's why I've attached the actual file and not a patch).

I've moved it down a directory as well, so it's now at the same level as build.xml and build_common.xml.

When I run this script it successfully runs the tests but about half of them fail.  I don't know if that's down to the code genuinely failing the tests or something to do with the script or infrastructure as I've set it up.

I'm still missing the list of categories so that I can cut/paste the task on line 119 for each one.  Can someone help me there please?

Also missing is installing the policy providers as described in the original tests README.  They have to be done as root, but obviously you wouldn't want to run the whole thing root and I haven't figured out how (or if) to do that in Ant.

I confess to being some what stuck on this until I get the list of categories and figure the policy provider copy thing.

Any ideas?

> Move the tests into the JUnit framework inside the main source project
> ----------------------------------------------------------------------
>
>                 Key: RIVER-301
>                 URL: https://issues.apache.org/jira/browse/RIVER-301
>             Project: River
>          Issue Type: Task
>          Components: other
>    Affects Versions: AR3
>            Reporter: Tom Hobbs
>         Attachments: integrationtest.xml, RIVER-301.patch, RIVER-301.patch, River-301.patch.zip
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> The tests donated by SUN live in their own source project and are runnable in a format that is unfriendly towards IDEs and new developers to the River project.
> This is the proposal to move the test code, mostly unmodified, into the main source directory whilst shoe-horning it into JUnit 3.  This will allow it to be easily viewable and runnable.  Such a structure will also reduce the code-compile-test cycle since no JARs will have to be created in the middle of the cycle and no long command-line incantations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (RIVER-301) Move the tests into the JUnit framework inside the main source project

Posted by Jonathan Costers <jo...@googlemail.com>.
2009/3/17 Tom Hobbs (JIRA) <ji...@apache.org>

>
>     [
> https://issues.apache.org/jira/browse/RIVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Tom Hobbs updated RIVER-301:
> ----------------------------
>
>     Attachment: integrationtest.xml
>
> This is the new file.
>
> (Sorry, the "create patch" option seems to have fallen off my IDE and it
> was late when I tried to get it done last night and that's why I've attached
> the actual file and not a patch).
>
> I've moved it down a directory as well, so it's now at the same level as
> build.xml and build_common.xml.
>
> When I run this script it successfully runs the tests but about half of
> them fail.  I don't know if that's down to the code genuinely failing the
> tests or something to do with the script or infrastructure as I've set it
> up.


When I build and run the QA suite using the original make file, also about
half of the tests fail. Haven't been able to figure out why exactly yet. It
gives me exceptions on shared activation group etc. I will post some more
info when I'm back home in a couple of days and have access to a Linux box.


>
>
> I'm still missing the list of categories so that I can cut/paste the task
> on line 119 for each one.  Can someone help me there please?


Apart from the README file which lists some examples, I am not able to find
them up until now either ..


>
>
> Also missing is installing the policy providers as described in the
> original tests README.  They have to be done as root, but obviously you
> wouldn't want to run the whole thing root and I haven't figured out how (or
> if) to do that in Ant.


I believe the same can be achieved by using a system property for specifying
extension directories to the JDK. You don't have to install the JAR policy
provider file in the JRE ext directory. But let me test this out.

I confess to being some what stuck on this until I get the list of
> categories and figure the policy provider copy thing.
>
> Any ideas?
>
> > Move the tests into the JUnit framework inside the main source project
> > ----------------------------------------------------------------------
> >
> >                 Key: RIVER-301
> >                 URL: https://issues.apache.org/jira/browse/RIVER-301
> >             Project: River
> >          Issue Type: Task
> >          Components: other
> >    Affects Versions: AR3
> >            Reporter: Tom Hobbs
> >         Attachments: integrationtest.xml, RIVER-301.patch,
> RIVER-301.patch, River-301.patch.zip
> >
> >   Original Estimate: 672h
> >  Remaining Estimate: 672h
> >
> > The tests donated by SUN live in their own source project and are
> runnable in a format that is unfriendly towards IDEs and new developers to
> the River project.
> > This is the proposal to move the test code, mostly unmodified, into the
> main source directory whilst shoe-horning it into JUnit 3.  This will allow
> it to be easily viewable and runnable.  Such a structure will also reduce
> the code-compile-test cycle since no JARs will have to be created in the
> middle of the cycle and no long command-line incantations.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>