You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by nir-sopher <gi...@git.apache.org> on 2017/01/25 17:07:02 UTC
[GitHub] incubator-trafficcontrol pull request #230: Allowing variables in traffic-se...
GitHub user nir-sopher opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/230
Allowing variables in traffic-server's profile derived parameters
Supporting __CACHE_IPV4__, __CACHE_IPV6__.
Adding additional variables should be even more simple and safe.
Tested with Kabletown example:
Setting LOCAL proxy.local.incoming_ip_to_bind __CAHCE_IPv4__ [__CAHCE_IPv6__]
and finding
LOCAL proxy.local.incoming_ip_to_bind 10.10.2.4 [2033:D0D0:3300::2:4/64]
In http://127.0.0.1:3000/genfiles/view/atsec-chi-02/records.config
Br.
Nir
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nir-sopher/incubator-trafficcontrol vars
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 79fcfbe9b3ad8ecc0a2064b5b6c15a0fe5861d07
Author: Nir B. Sopher <ni...@gmail.com>
Date: 2017-01-01T15:30:37Z
Merge pull request #1 from apache/master
Updating my fork
commit 117136885159baa178eb3ee163a7ee8d7c269222
Author: Nir B. Sopher <ni...@gmail.com>
Date: 2017-01-23T19:14:13Z
Merge pull request #2 from apache/master
Update my fork
commit ecb2938ad6e61ba14cb128459e5be6efdb8d53f4
Author: Nir B. Sopher <ni...@qwilt.com>
Date: 2017-01-25T05:44:08Z
Basic variables support in traffic-server profile derived config files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #230: Allowing variables in traffic-server's ...
Posted by nir-sopher <gi...@git.apache.org>.
Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/230
Cool!
I was started to look for a way to integrate the 2.
Thank you!
Nir
On Wed, Jan 25, 2017 at 7:16 PM, Jeremy Mitchell <no...@github.com>
wrote:
> @nir-sopher <https://github.com/nir-sopher> - if you rename this PR
> "[TC-121] Allowing variables in traffic-server's profile derived
> parameters" I think it will link it to the jira issue...
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-trafficcontrol/pull/230#issuecomment-275170701>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AXGkYEvpBI5yqvff1ZGEVslicZDL1v8Uks5rV4NZgaJpZM4LtvhK>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #230: [TC-121] Allowing variables in t...
Posted by nir-sopher <gi...@git.apache.org>.
Github user nir-sopher closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #230: [TC-121] Allowing variables in traffic-...
Posted by nir-sopher <gi...@git.apache.org>.
Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/230
Closing from now, need to look further into the changes in the files generation code in order to fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #230: Allowing variables in traffic-server's ...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/230
@nir-sopher - if you rename this PR "[TC-121] Allowing variables in traffic-server's profile derived parameters" I think it will link it to the jira issue...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #230: [TC-121] Allowing variables in traffic-...
Posted by nir-sopher <gi...@git.apache.org>.
Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/230
PR was rebased so it cam be merged. However, it still needs to be verified again by adding a record to records.config and checking the value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---