[GitHub] [netbeans] mbien edited a comment on pull request #3558: maven indexing lucene renovation

[GitBox <gi...@apache.org>]

mbien edited a comment on pull request #3558:
URL: https://github.com/apache/netbeans/pull/3558#issuecomment-1041044529


   It turned out that the reason for `findClassUsages()` not returning any hits was `maven-indexer`producing lower case based queries, while `ClassDependencyIndexCreator` encodes class dependencies in searchable Base64 encoded CRC32 Strings. This worked for some reason with old lucene (maybe searches were case insensitive?) but fails now after the lucene upgrade. But even if it worked before, it is likely still a bug since it could produce false positives if I see this correctly.
   
   This [hack](https://github.com/apache/netbeans/pull/3558/commits/98d4f336875323f0ed05b00d0241189e61daf55b) simulates the old behavior and lets all tests pass locally.
   
   potential fix: encode with Base32 instead (in lowercase) or find other solution preferably via lucene.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists