You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/01 15:13:51 UTC
[GitHub] [camel] orpiske opened a new pull request, #8087: (chores) camel-endpointdsl: use unique data directory for tests
orpiske opened a new pull request, #8087:
URL: https://github.com/apache/camel/pull/8087
This helps prevents misbehaved tests from causing other tests to fail
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8087: (chores) camel-endpointdsl: use unique data directory for tests
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8087:
URL: https://github.com/apache/camel/pull/8087#issuecomment-1201413256
> What about using the [TempDirectory extension](https://www.baeldung.com/junit-5-temporary-directory)?
So, this is a very cool feature of JUnit. I didn't know about it. However, I won't do this one for now. We have a lot more code that could be converted / cleanup with this, so I want to look at it with more time (please, do feel free to create an issue on Jira if you want).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #8087: (chores) camel-endpointdsl: use unique data directory for tests
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8087:
URL: https://github.com/apache/camel/pull/8087#issuecomment-1201394804
If you don't want it to be merged, you should convert it to a draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8087: (chores) camel-endpointdsl: use unique data directory for tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8087:
URL: https://github.com/apache/camel/pull/8087#issuecomment-1201412944
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #8087: (chores) camel-endpointdsl: use unique data directory for tests
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8087:
URL: https://github.com/apache/camel/pull/8087#issuecomment-1201387811
What about using the [TempDirectory extension](https://www.baeldung.com/junit-5-temporary-directory)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8087: (chores) camel-endpointdsl: use unique data directory for tests
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8087:
URL: https://github.com/apache/camel/pull/8087#issuecomment-1201390812
> What about using the [TempDirectory extension](https://www.baeldung.com/junit-5-temporary-directory)?
I confess I don't know about this one. Let me take a look and see how it goes. (so, please, don't merge it yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #8087: (chores) camel-endpointdsl: use unique data directory for tests
Posted by GitBox <gi...@apache.org>.
orpiske merged PR #8087:
URL: https://github.com/apache/camel/pull/8087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org