You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "John Hjelmstad (JIRA)" <ji...@apache.org> on 2008/09/04 01:53:44 UTC

[jira] Updated: (SHINDIG-503) Augment Gadget object to maintain both String and Parse Tree rendering state

     [ https://issues.apache.org/jira/browse/SHINDIG-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Hjelmstad updated SHINDIG-503:
-----------------------------------

    Attachment: gadget-parsetree-state.diff

Patch- part 1 attached. This patch augments Gadget as described, adding getParseTree() to it and maintaining consistency between Parse Tree and String representations of Content.

The big concern is abuse of these APIs leading to poor rewriting performance (and potentially an incentive to use them for other ugly purposes), but IMO right now the pros outweigh the cons, and performance can be managed by proper ordering of rewriters and code reviews. After all, the committers list is presently still small enough that we can self-police.

> Augment Gadget object to maintain both String and Parse Tree rendering state
> ----------------------------------------------------------------------------
>
>                 Key: SHINDIG-503
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-503
>             Project: Shindig
>          Issue Type: Sub-task
>          Components: Gadget Rendering Server (Java)
>            Reporter: John Hjelmstad
>            Assignee: John Hjelmstad
>         Attachments: gadget-parsetree-state.diff
>
>
> Point #4 of http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200808.mbox/%3cab5e78ed0808061534r48c04de5j8909bc7e8316cc22@mail.gmail.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.