You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/10/13 09:32:52 UTC
[I] Support MySQL/Oracle drop table statement convert to SqlDropTable to improve sql federation support [shardingsphere]
strongduanmu opened a new issue, #28753:
URL: https://github.com/apache/shardingsphere/issues/28753
## Background
On the master branch, [SQLNodeConverterEngine](https://github.com/apache/shardingsphere/blob/master/kernel/sql-federation/core/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/converter/SQLNodeConverterEngine.java) already supports the conversion of most SelectStatement statements, which provides a good foundation for sql federation. In order to improve the support of sql federation for drop table statement, we need to support the conversion of DropTableStatement in SQLNodeConverterEngine.
MySQL drop table statement doc - https://dev.mysql.com/doc/refman/8.0/en/drop-table.html
```
DROP [TEMPORARY] TABLE [IF EXISTS]
tbl_name [, tbl_name] ...
[RESTRICT | CASCADE]
```
Oracle drop table statement doc - https://docs.oracle.com/cd/E11882_01/server.112/e41084/statements_9003.htm
## Task
- [ ] add DropTableStatementConverter implement, you can refer - https://github.com/polardb/polardbx-sql/blob/cdd976850bdfc3264dff279198b6b06eb8641fbe/polardbx-optimizer/src/main/java/com/alibaba/polardbx/optimizer/parse/visitor/FastSqlToCalciteNodeVisitor.java#L786
- [ ] add DropTableStatementConverter call logic in SQLNodeConverterEngine
- [ ] add drop table statement convert test case in `resources/converter` directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support MySQL/Oracle drop table statement convert to SqlDropTable to improve sql federation support [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #28753:
URL: https://github.com/apache/shardingsphere/issues/28753#issuecomment-1772541901
Since Calcite has very low support for DDL, this task is difficult to complete and I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support MySQL/Oracle drop table statement convert to SqlDropTable to improve sql federation support [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #28753: Support MySQL/Oracle drop table statement convert to SqlDropTable to improve sql federation support
URL: https://github.com/apache/shardingsphere/issues/28753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support MySQL/Oracle drop table statement convert to SqlDropTable to improve sql federation support [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #28753:
URL: https://github.com/apache/shardingsphere/issues/28753#issuecomment-1765702074
@chakkk309 Welcome back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support MySQL/Oracle drop table statement convert to SqlDropTable to improve sql federation support [shardingsphere]
Posted by "chakkk309 (via GitHub)" <gi...@apache.org>.
chakkk309 commented on issue #28753:
URL: https://github.com/apache/shardingsphere/issues/28753#issuecomment-1765628426
Hi, i would like to try it, plz assign to me~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org