You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/09/08 11:48:05 UTC
[GitHub] [cordova-plugin-splashscreen] erisu opened a new pull request, #337: feat(android)!: remove platform from plugin
erisu opened a new pull request, #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Remove the Android platform code and documentation from the plugin repo as Android 12 Splash Screen API has been integrated as core for cordova-android.
### Description
<!-- Describe your changes in detail -->
Removed anything related to Android except from the past RELEASENOTES.
`ISSUE_TEMPLATE.md`, `PULL_REQUEST_TEMPLATE.md`, and `BUG_REPORT.md` was also excluded because these files are managed by a script that would update across all repos. Also the usage of the platform was written in the context of providing an example.
### Testing
<!-- Please describe in detail how you tested your changes. -->
n/a
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a diff in pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#discussion_r966122259
##########
package.json:
##########
@@ -27,15 +25,10 @@
},
"engines": {
"cordovaDependencies": {
- "2.0.0": {
Review Comment:
Maybe it could be kept, but I don't think such information is necessary to keep as we can pull up the JSON file from the tag.
I also don't know if these versions were ever used. We had to declare the same information in plugin.xml file for the version that was being installed. I think it was read from there.
Anyone else have any opinion on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#issuecomment-1242007976
Reading it again, it talks about installing version 0.0.1 of the plugin, that will combine the values since all the entries are valid for version 0.0.1, but since we want to install 7.0.0, I have no idea how it should work in that case, so I’ll just approve and we can fix it in the future if something breaks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#issuecomment-1241983588
I was expecting it to have the same that we have in plugin.xml
`<engine name="cordova-windows" version=">=4.4.0" />`
but according to this, it looks like they combine values of previous versions, so shouldn’t be needed
https://github.com/apache/cordova-discuss/pull/30/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a diff in pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#discussion_r966122259
##########
package.json:
##########
@@ -27,15 +25,10 @@
},
"engines": {
"cordovaDependencies": {
- "2.0.0": {
Review Comment:
Maybe it could be kept, but I don't think such information is necessary to keep as we can pull up the JSON file from the tag.
I also don't know if these versions were ever used. We had to declare the same information in plugin.xml file for the version that was being installed. I think it was read from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a diff in pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#discussion_r966622787
##########
package.json:
##########
@@ -27,15 +25,10 @@
},
"engines": {
"cordovaDependencies": {
- "2.0.0": {
Review Comment:
Restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu merged pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
erisu merged PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
erisu commented on PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#issuecomment-1241930359
I have no plans to remove the Windows code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] NiklasMerz commented on a diff in pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on code in PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#discussion_r966106874
##########
package.json:
##########
@@ -27,15 +25,10 @@
},
"engines": {
"cordovaDependencies": {
- "2.0.0": {
Review Comment:
We could keep these version to see how it was used in the past if someone looks at the current package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on a diff in pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on code in PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#discussion_r966351611
##########
package.json:
##########
@@ -27,15 +25,10 @@
},
"engines": {
"cordovaDependencies": {
- "2.0.0": {
Review Comment:
I have never understand how the engines work, or are supposed to work, but as I understand it, it would install an older version of the plugin based on the installed platform version if necessary. So I think it should not be removed, but I’m not certainly sure.
but the version 7 engines should be updated as at the moment it will prevent the install on any CLI version since it has the > 100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on pull request #337: feat(android)!: remove platform from plugin
Posted by GitBox <gi...@apache.org>.
erisu commented on PR #337:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/337#issuecomment-1241935129
What do you expect to be written in version 7?
"6.0.2" already stops installing of Android and anything above that, there is no code to install and I have no expectations for anyone pushing anything to 6.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org