You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/01/03 06:54:02 UTC

[PR] [pipelineX](fix) Fix query cancel timeout [doris]

Gabriel39 opened a new pull request, #29460:
URL: https://github.com/apache/doris/pull/29460

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875158185

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.52 seconds
    stream load tsv:          581 seconds loaded 74807831229 Bytes, about 122 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.4 seconds inserted 10000000 Rows, about 352K ops/s
    storage size: 17183823819 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #29460:
URL: https://github.com/apache/doris/pull/29460#discussion_r1440341678


##########
be/src/vec/exec/scan/scanner_context.cpp:
##########
@@ -428,6 +428,7 @@ bool ScannerContext::set_status_on_error(const Status& status, bool need_lock) {
         _status_error = true;
         _blocks_queue_added_cv.notify_one();
         _should_stop = true;
+        _state->get_query_ctx()->set_exec_status(_process_status);

Review Comment:
   why need set this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874962501

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 47.02 seconds
    stream load tsv:          564 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.2 seconds inserted 10000000 Rows, about 354K ops/s
    storage size: 17188141470 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875141835

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 115b200f5c76f0630280454bfd6aab03f9ef0711, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	5420	5145	5232	5145
   q2	383	154	141	141
   q3	1460	1202	1187	1187
   q4	1087	841	762	762
   q5	3131	3148	3145	3145
   q6	226	141	138	138
   q7	967	556	537	537
   q8	2167	2203	2264	2203
   q9	6710	6683	6620	6620
   q10	3158	3119	3126	3119
   q11	350	229	233	229
   q12	377	237	243	237
   q13	4404	3677	3627	3627
   q14	250	216	216	216
   q15	617	551	547	547
   q16	460	412	408	408
   q17	1046	504	468	468
   q18	7063	6739	6828	6739
   q19	1636	1586	1503	1503
   q20	588	354	356	354
   q21	2842	2465	2495	2465
   q22	394	336	339	336
   Total cold run time: 44736 ms
   Total hot run time: 40126 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	5103	4990	5133	4990
   q2	340	267	246	246
   q3	3363	3336	3283	3283
   q4	2140	2018	2011	2011
   q5	5918	5917	5933	5917
   q6	230	129	126	126
   q7	2356	1925	1959	1925
   q8	3527	3648	3683	3648
   q9	9074	9027	9050	9027
   q10	3865	3919	3936	3919
   q11	581	487	484	484
   q12	800	638	662	638
   q13	3887	3240	3187	3187
   q14	305	279	287	279
   q15	603	558	544	544
   q16	533	501	525	501
   q17	2043	1784	1804	1784
   q18	8725	8312	8288	8288
   q19	1760	1695	1653	1653
   q20	2275	1997	1977	1977
   q21	5573	5421	5209	5209
   q22	579	502	481	481
   Total cold run time: 63580 ms
   Total hot run time: 60117 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875133339

   TeamCity be ut coverage result:
    Function Coverage: 36.61% (8612/23524) 
    Line Coverage: 28.66% (69979/244168)
    Region Coverage: 27.64% (36223/131038)
    Branch Coverage: 24.34% (18505/76018)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/115b200f5c76f0630280454bfd6aab03f9ef0711_115b200f5c76f0630280454bfd6aab03f9ef0711/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874926513

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874952259

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 23dacc3137ab141596e599396d266d3aed979cdd, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	5455	5063	5222	5063
   q2	393	162	158	158
   q3	1494	1183	1159	1159
   q4	1094	825	832	825
   q5	3138	3128	3139	3128
   q6	223	141	130	130
   q7	985	560	527	527
   q8	2162	2278	2246	2246
   q9	6703	6653	6641	6641
   q10	3171	3186	3103	3103
   q11	354	217	215	215
   q12	378	238	231	231
   q13	4406	3641	3626	3626
   q14	256	225	213	213
   q15	608	550	546	546
   q16	480	412	418	412
   q17	1043	541	571	541
   q18	7054	6768	6772	6768
   q19	1645	1544	1448	1448
   q20	606	347	328	328
   q21	2861	2534	2574	2534
   q22	394	331	317	317
   Total cold run time: 44903 ms
   Total hot run time: 40159 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	5165	5092	5055	5055
   q2	344	241	251	241
   q3	3357	3327	3283	3283
   q4	2160	2054	2046	2046
   q5	5940	5914	5933	5914
   q6	230	124	125	124
   q7	2373	2003	1923	1923
   q8	3541	3645	3664	3645
   q9	9122	9006	8969	8969
   q10	3867	3891	3902	3891
   q11	580	490	497	490
   q12	806	639	644	639
   q13	3904	3191	3191	3191
   q14	306	281	294	281
   q15	601	555	545	545
   q16	590	511	503	503
   q17	2048	1819	1831	1819
   q18	8811	8385	8727	8385
   q19	1737	1660	1639	1639
   q20	2289	1992	1965	1965
   q21	5669	5301	5321	5301
   q22	553	499	527	499
   Total cold run time: 63993 ms
   Total hot run time: 60348 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874951022

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 23dacc3137ab141596e599396d266d3aed979cdd, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18082	5207	5152	5152
   q2	2027	157	157	157
   q3	10597	1101	1174	1101
   q4	10207	784	849	784
   q5	7854	2841	2973	2841
   q6	213	133	129	129
   q7	936	523	536	523
   q8	9279	2053	2035	2035
   q9	6854	6422	6428	6422
   q10	8252	3042	3042	3042
   q11	437	201	203	201
   q12	389	230	229	229
   q13	18007	3602	3659	3602
   q14	241	226	225	225
   q15	576	540	538	538
   q16	473	401	415	401
   q17	986	478	500	478
   q18	7384	6698	6665	6665
   q19	1610	1388	1389	1388
   q20	715	347	354	347
   q21	2801	2371	2423	2371
   q22	379	312	318	312
   Total cold run time: 108299 ms
   Total hot run time: 38943 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5124	5096	5081	5081
   q2	341	248	251	248
   q3	3303	3269	3240	3240
   q4	2116	1999	2003	1999
   q5	5815	5769	5772	5769
   q6	211	125	121	121
   q7	2320	1842	1885	1842
   q8	3377	3424	3473	3424
   q9	8778	8795	8723	8723
   q10	3803	3856	3835	3835
   q11	585	491	500	491
   q12	803	657	653	653
   q13	6501	3178	3183	3178
   q14	290	294	262	262
   q15	588	530	528	528
   q16	548	506	526	506
   q17	1954	1794	1736	1736
   q18	8696	8523	8225	8225
   q19	1636	1612	1630	1612
   q20	2216	1950	1963	1950
   q21	5579	5268	5149	5149
   q22	585	492	484	484
   Total cold run time: 65169 ms
   Total hot run time: 59056 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #29460:
URL: https://github.com/apache/doris/pull/29460#discussion_r1440341022


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -574,27 +574,29 @@ Status FragmentMgr::start_query_execution(const PExecPlanFragmentStartRequest* r
 
 void FragmentMgr::remove_pipeline_context(
         std::shared_ptr<pipeline::PipelineFragmentContext> f_context) {
-    std::lock_guard<std::mutex> lock(_lock);
-    auto query_id = f_context->get_query_id();
     auto* q_context = f_context->get_query_ctx();
-    std::vector<TUniqueId> ins_ids;
-    f_context->instance_ids(ins_ids);
-    bool all_done = q_context->countdown(ins_ids.size());
-    for (const auto& ins_id : ins_ids) {
-        {
-            std::lock_guard<std::mutex> plock(q_context->pipeline_lock);
-            if (q_context->fragment_id_to_pipeline_ctx.contains(f_context->get_fragment_id())) {
-                q_context->fragment_id_to_pipeline_ctx.erase(f_context->get_fragment_id());
-            }
+    {
+        std::lock_guard<std::mutex> lock(_lock);
+        auto query_id = f_context->get_query_id();
+        std::vector<TUniqueId> ins_ids;
+        f_context->instance_ids(ins_ids);
+        bool all_done = q_context->countdown(ins_ids.size());
+        for (const auto& ins_id : ins_ids) {
+            LOG_INFO("Removing query {} instance {}, all done? {}", print_id(query_id),
+                     print_id(ins_id), all_done);
+            _pipeline_map.erase(ins_id);
+            g_pipeline_fragment_instances_count << -1;
+        }
+        if (all_done) {
+            LOG_INFO("Query {} finished", print_id(query_id));
+            _query_ctx_map.erase(query_id);
         }
-        LOG_INFO("Removing query {} instance {}, all done? {}", print_id(query_id),
-                 print_id(ins_id), all_done);
-        _pipeline_map.erase(ins_id);
-        g_pipeline_fragment_instances_count << -1;
     }
-    if (all_done) {
-        LOG_INFO("Query {} finished", print_id(query_id));
-        _query_ctx_map.erase(query_id);
+    {
+        std::lock_guard<std::mutex> plock(q_context->pipeline_lock);

Review Comment:
   这里,拿着context 的lock,然后访问context 内部的map,感觉把这堆代码,在query context 中单独封装一个函数做更合理。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875286764

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875286802

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875107508

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29460:
URL: https://github.com/apache/doris/pull/29460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874928459

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874952307

   TeamCity be ut coverage result:
    Function Coverage: 36.61% (8613/23524) 
    Line Coverage: 28.66% (69986/244169)
    Region Coverage: 27.64% (36223/131038)
    Branch Coverage: 24.34% (18500/76018)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/23dacc3137ab141596e599396d266d3aed979cdd_23dacc3137ab141596e599396d266d3aed979cdd/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875154572

   
   TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
   ```
   TPC-DS sf100 test result on commit 115b200f5c76f0630280454bfd6aab03f9ef0711, data reload: false
   
   run tpcds-sf100 query with default conf and session variables
   query1	871	344	336	336
   query2	5584	1892	1892	1892
   query3	6649	202	198	198
   query4	25018	22502	22567	22502
   query5	4014	552	554	552
   query6	283	192	199	192
   query7	4524	285	285	285
   query8	246	221	222	221
   query9	8255	2555	2691	2555
   query10	376	270	240	240
   query11	16139	15614	15626	15614
   query12	126	86	74	74
   query13	1532	329	337	329
   query14	11392	7391	7437	7391
   query15	354	211	220	211
   query16	6272	269	254	254
   query17	1697	530	526	526
   query18	1923	264	265	264
   query19	272	151	150	150
   query20	77	77	80	77
   query21	191	101	102	101
   query22	4759	4763	4828	4763
   query23	32304	31487	31232	31232
   query24	12240	3459	3457	3457
   query25	589	373	361	361
   query26	1409	157	152	152
   query27	2598	288	287	287
   query28	6383	1969	1971	1969
   query29	1416	412	416	412
   query30	291	148	153	148
   query31	1063	771	811	771
   query32	83	60	54	54
   query33	678	290	283	283
   query34	826	450	447	447
   query35	926	784	738	738
   query36	1341	1165	1234	1165
   query37	180	79	71	71
   query38	3439	3334	3305	3305
   query39	1367	1300	1311	1300
   query40	287	94	92	92
   query41	38	39	38	38
   query42	92	95	91	91
   query43	511	487	508	487
   query44	1045	716	727	716
   query45	243	222	215	215
   query46	1163	805	799	799
   query47	1775	1570	1613	1570
   query48	368	285	286	285
   query49	1014	325	324	324
   query50	1123	878	852	852
   query51	5448	5316	5291	5291
   query52	96	81	92	81
   query53	205	175	184	175
   query54	1225	596	594	594
   query55	93	91	86	86
   query56	204	196	201	196
   query57	1005	985	964	964
   query58	230	212	205	205
   query59	2760	2618	2554	2554
   query60	254	232	241	232
   query61	86	82	85	82
   query62	1390	488	515	488
   query63	191	166	170	166
   query64	5701	1746	1703	1703
   query65	3344	3257	3292	3257
   query66	965	341	337	337
   query67	15619	15346	15405	15346
   query68	11107	526	512	512
   query69	529	255	255	255
   query70	1737	1498	1445	1445
   query71	516	225	227	225
   query72	6633	4020	3994	3994
   query73	2286	311	315	311
   query74	6916	6503	6544	6503
   query75	5399	2257	2290	2257
   query76	6297	1196	1131	1131
   query77	682	278	298	278
   query78	9110	8904	8759	8759
   query79	1107	557	539	539
   query80	547	386	384	384
   query81	478	216	218	216
   query82	191	103	103	103
   query83	161	138	138	138
   query84	255	54	53	53
   query85	849	277	279	277
   query86	392	402	372	372
   query87	3584	3377	3456	3377
   query88	3121	2271	2283	2271
   query89	376	291	303	291
   query90	1731	207	209	207
   query91	116	88	93	88
   query92	61	52	57	52
   query93	2717	503	447	447
   query94	723	178	184	178
   query95	457	424	406	406
   query96	628	318	317	317
   query97	4288	4154	4186	4154
   query98	206	198	188	188
   query99	1628	891	975	891
   Total cold run time: 288990 ms
   Total hot run time: 182724 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1874960194

   
   TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
   ```
   TPC-DS sf100 test result on commit 23dacc3137ab141596e599396d266d3aed979cdd, data reload: false
   
   run tpcds-sf100 query with default conf and session variables
   query1	927	351	333	333
   query2	5071	1985	1893	1893
   query3	6651	206	199	199
   query4	26968	22577	22412	22412
   query5	4607	560	529	529
   query6	277	182	179	179
   query7	4587	286	265	265
   query8	235	230	199	199
   query9	8215	2549	2705	2549
   query10	452	268	267	267
   query11	16207	15600	15379	15379
   query12	136	79	77	77
   query13	1650	333	338	333
   query14	11125	7181	7178	7178
   query15	254	188	187	187
   query16	6058	272	270	270
   query17	1808	505	494	494
   query18	1743	278	260	260
   query19	288	140	134	134
   query20	87	76	78	76
   query21	176	97	93	93
   query22	5130	4568	4720	4568
   query23	32111	31331	31273	31273
   query24	11948	2810	2810	2810
   query25	575	356	342	342
   query26	1677	142	144	142
   query27	2857	287	287	287
   query28	6978	1967	1967	1967
   query29	1649	391	380	380
   query30	282	147	149	147
   query31	960	764	786	764
   query32	91	62	58	58
   query33	720	280	275	275
   query34	852	440	449	440
   query35	882	784	787	784
   query36	1326	1237	1184	1184
   query37	176	72	73	72
   query38	3376	3286	3257	3257
   query39	1324	1292	1269	1269
   query40	288	89	92	89
   query41	39	37	35	35
   query42	95	92	92	92
   query43	541	520	498	498
   query44	1068	706	718	706
   query45	192	181	181	181
   query46	1067	639	638	638
   query47	1636	1561	1529	1529
   query48	334	259	258	258
   query49	1123	327	335	327
   query50	751	328	365	328
   query51	5376	5216	5277	5216
   query52	102	86	95	86
   query53	216	161	147	147
   query54	1233	575	573	573
   query55	99	85	87	85
   query56	206	201	202	201
   query57	1057	948	981	948
   query58	225	204	199	199
   query59	2857	2612	2664	2612
   query60	261	224	240	224
   query61	90	88	85	85
   query62	670	447	456	447
   query63	166	149	147	147
   query64	5409	1742	1725	1725
   query65	3303	3257	3249	3249
   query66	1247	344	329	329
   query67	15656	15879	15852	15852
   query68	11398	528	535	528
   query69	536	256	257	256
   query70	1622	1504	1490	1490
   query71	504	226	222	222
   query72	5845	3585	3593	3585
   query73	2198	310	316	310
   query74	7017	6357	6416	6357
   query75	5222	2270	2271	2270
   query76	6329	1130	1147	1130
   query77	652	287	282	282
   query78	9133	8560	8628	8560
   query79	1042	515	516	515
   query80	549	383	368	368
   query81	472	208	205	205
   query82	193	109	103	103
   query83	166	139	138	138
   query84	251	52	55	52
   query85	913	284	281	281
   query86	395	389	393	389
   query87	3553	3393	3392	3392
   query88	2970	2274	2269	2269
   query89	337	251	260	251
   query90	1900	193	209	193
   query91	126	92	92	92
   query92	58	52	58	52
   query93	1584	504	494	494
   query94	789	191	191	191
   query95	467	432	415	415
   query96	617	319	316	316
   query97	4316	4175	4165	4165
   query98	215	211	200	200
   query99	1072	814	831	814
   Total cold run time: 288184 ms
   Total hot run time: 180016 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875113550

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [pipelineX](fix) Fix query cancel timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29460:
URL: https://github.com/apache/doris/pull/29460#issuecomment-1875139625

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 115b200f5c76f0630280454bfd6aab03f9ef0711, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17772	5348	5127	5127
   q2	2028	164	144	144
   q3	10606	1179	1074	1074
   q4	10277	796	807	796
   q5	7813	2948	2800	2800
   q6	218	134	133	133
   q7	956	557	503	503
   q8	9249	2014	2034	2014
   q9	6870	6406	6350	6350
   q10	8260	3050	3036	3036
   q11	426	219	216	216
   q12	387	235	233	233
   q13	17990	3622	3622	3622
   q14	244	214	204	204
   q15	574	541	531	531
   q16	445	405	416	405
   q17	962	493	518	493
   q18	7456	6772	6661	6661
   q19	1595	1361	1416	1361
   q20	727	362	353	353
   q21	2765	2404	2388	2388
   q22	379	311	327	311
   Total cold run time: 107999 ms
   Total hot run time: 38755 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5155	5093	5095	5093
   q2	336	242	231	231
   q3	3329	3304	3243	3243
   q4	2108	2019	2059	2019
   q5	5803	5810	5782	5782
   q6	214	126	123	123
   q7	2299	1917	1952	1917
   q8	3391	3489	3503	3489
   q9	8841	8760	8751	8751
   q10	3777	3851	3881	3851
   q11	597	487	497	487
   q12	796	611	655	611
   q13	6402	3189	3165	3165
   q14	287	267	283	267
   q15	609	533	519	519
   q16	541	507	514	507
   q17	1924	1785	1755	1755
   q18	8679	8347	8285	8285
   q19	1629	1605	1562	1562
   q20	2214	1991	1957	1957
   q21	5565	5211	5228	5211
   q22	544	482	461	461
   Total cold run time: 65040 ms
   Total hot run time: 59286 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org