You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/11/30 23:39:53 UTC

Review Request 54236: HIVE-15296 AM may lose task failures and not reschedule when scheduling to LLAP

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54236/
-----------------------------------------------------------

Review request for hive, Prasanth_J and Siddharth Seth.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java 4933fb3 
  llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java 0581681 
  llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java ea47330 
  llap-common/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java 9549567 
  llap-common/src/protobuf/LlapDaemonProtocol.proto 2e74c18 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 04c28cb 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 91a321d 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 752e6ee 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 0deebf9 

Diff: https://reviews.apache.org/r/54236/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 54236: HIVE-15296 AM may lose task failures and not reschedule when scheduling to LLAP

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54236/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 2:28 a.m.)


Review request for hive, Prasanth_J and Siddharth Seth.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java 4933fb3 
  llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java 0581681 
  llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java ea47330 
  llap-common/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java 9549567 
  llap-common/src/protobuf/LlapDaemonProtocol.proto 2e74c18 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 04c28cb 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 91a321d 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 752e6ee 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 0deebf9 

Diff: https://reviews.apache.org/r/54236/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 54236: HIVE-15296 AM may lose task failures and not reschedule when scheduling to LLAP

Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54236/#review158235
-----------------------------------------------------------




llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java (line 191)
<https://reviews.apache.org/r/54236/#comment229028>

    This is async update to an object in the pending events queue.
    
    Possible sync issues?


- Gopal V


On Nov. 30, 2016, 11:39 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54236/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:39 p.m.)
> 
> 
> Review request for hive, Prasanth_J and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java 4933fb3 
>   llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java 0581681 
>   llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java ea47330 
>   llap-common/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java 9549567 
>   llap-common/src/protobuf/LlapDaemonProtocol.proto 2e74c18 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 04c28cb 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 91a321d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 752e6ee 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 0deebf9 
> 
> Diff: https://reviews.apache.org/r/54236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>