You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/08/17 19:37:13 UTC
[GitHub] [incubator-brpc] zyearn opened a new issue, #1894: Remove implementation specific function name of EventDispatcher
zyearn opened a new issue, #1894:
URL: https://github.com/apache/incubator-brpc/issues/1894
Some of the member functions of EventDispatcher is implementation specific, for example AddEpollOut.
We need to change that specific function name and adopt more general name then we can easily support brpc to more platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [I] Remove implementation specific function name of EventDispatcher (brpc)
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on issue #1894:
URL: https://github.com/apache/brpc/issues/1894#issuecomment-1855094311
Please review this pr as well @zyearn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] fansehep commented on issue #1894: Remove implementation specific function name of EventDispatcher
Posted by GitBox <gi...@apache.org>.
fansehep commented on issue #1894:
URL: https://github.com/apache/incubator-brpc/issues/1894#issuecomment-1272575919
这里只需改变```AddEpollOut``` 和 ```RemoveEpollOut``` 两个函数即可,
```AddEpollOut``` => ```AddMultiplex```
```RemoveEpollOut``` => ```RemoveMultiplex```
这样是否是一个合适的做法呢?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [I] Remove implementation specific function name of EventDispatcher (brpc)
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on issue #1894:
URL: https://github.com/apache/brpc/issues/1894#issuecomment-1837876067
I want to work on this issue @zyearn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [I] Remove implementation specific function name of EventDispatcher (brpc)
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on issue #1894:
URL: https://github.com/apache/brpc/issues/1894#issuecomment-1837875329
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org