[jira] Issue Comment Edited: (RIVER-301) Move the tests into the JUnit framework inside the main source project

["Jonathan Costers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RIVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688187#action_12688187 ] 

Jonathan Costers edited comment on RIVER-301 at 3/22/09 5:32 PM:
-----------------------------------------------------------------

Hi

After spending some time finding out how the QA test harness works, I made some progress on the integration of the tests into the main build process. I significantly updated integrationtests.xml.
Also, I consolidated the complete River build process into one build.xml file.

The attached patch (River-build-qa2.patch) should work fine, but is still work in progress. I just wanted to get this out so you can get a feel how the tests work.

The patch contains:
- consolidated scattered build.xml files into on build.xml in the project root directory
- cleaned up build process in build.xml according to Ant best practices
- updated integrationtests.xml, buildinq the QA suite in a similar way the make files did
- most QA suite JAR files have been identied and described in integrationtests.xml (conversion from GNUMake files is work in progress)
- running the QA suite works now with at least one test category

Instructions:
- apply the attached patch
- set JAVA_HOME
- ant build.release
- ant -f integrationtests.xml run.qa

Next steps:
- find out whether we can use -Djava.ext.dirs instead of (manually) installing policy providers in $JAVA_HOME/jre/lib/ext
- complete the conversion of QA suite make files and identify additional JARs to build
- cleanup
- consolidate tests into build.xml

Please let me know if this patch (River-build-qa2.patch) can be applied.

PS: On the test categories: all packages under com.sun.jini.test.impl and com.sun.jini.test.spec are test categories. 

      was (Author: jcosters):
    Hi

After spending some time finding out how the QA test harness works, I made some progress on the integration of the tests into the main build process. I significantly updated integrationtests.xml.
Also, I consolidated the complete River build process into one build.xml file.

The attached patch should work fine, but is still work in progress. I just wanted to get this out so you can get a feel how the tests work.

The patch contains:
- consolidated scattered build.xml files into on build.xml in the project root directory
- cleaned up build process in build.xml according to Ant best practices
- updated integrationtests.xml, buildinq the QA suite in a similar way the make files did
- most QA suite JAR files have been identied and described in integrationtests.xml (conversion from GNUMake files is work in progress)
- running the QA suite works now with at least one test category

Instructions:
- apply the attached patch
- set JAVA_HOME
- ant build.release
- ant -f integrationtests.xml run.qa

Next steps:
- find out whether we can use -Djava.ext.dirs instead of (manually) installing policy providers in $JAVA_HOME/jre/lib/ext
- complete the conversion of QA suite make files and identify additional JARs to build
- cleanup
- consolidate tests into build.xml

Please let me know if this patch can be applied.

PS: On the test categories: all packages under com.sun.jini.test.impl and com.sun.jini.test.spec are test categories. 
  
> Move the tests into the JUnit framework inside the main source project
> ----------------------------------------------------------------------
>
>                 Key: RIVER-301
>                 URL: https://issues.apache.org/jira/browse/RIVER-301
>             Project: River
>          Issue Type: Task
>          Components: other
>    Affects Versions: AR3
>            Reporter: Tom Hobbs
>         Attachments: integrationtest.xml, RIVER-301.patch, RIVER-301.patch, River-301.patch.zip, River-build-qa2.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> The tests donated by SUN live in their own source project and are runnable in a format that is unfriendly towards IDEs and new developers to the River project.
> This is the proposal to move the test code, mostly unmodified, into the main source directory whilst shoe-horning it into JUnit 3.  This will allow it to be easily viewable and runnable.  Such a structure will also reduce the code-compile-test cycle since no JARs will have to be created in the middle of the cycle and no long command-line incantations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.