You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/07 11:10:03 UTC
[GitHub] [superset] ValentinC-BR opened a new issue #17010: Chart config is reset when changing the datasource
ValentinC-BR opened a new issue #17010:
URL: https://github.com/apache/superset/issues/17010
The chart configuration (time column and grain, metrics, filters, etc.) is lost if the dataset (= source table) is changed.
#### How to reproduce the bug
1. Edit a chart (or create a new one)
2. Click on change dataset
3. Choose another dataset
4. See error (the configuration is lost)
### Expected results
The chart configuration should remain unchanged
### Actual results
The chart configuration is lost
#### Screenshots
### Environment
(please complete the following information):
- browser type and version: Google Chrome Version 94.0.4606.71 (Oficial build) (x86_64)
- superset version: 1.3.0
- python version: 3.7.9
- node.js version: doesn't apply, I run on Kubernetes, using gunicorn as server
- source : AWS Athena
- any feature flags active: /
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
This bug wasn't present in Superset v1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-991207552
+1 on this issue, it's quite common for orgs to have multiple datasets that are identical in schema but different data size (eg, test, staging, production). A common workflow is to build charts against a test dataset then switch it over to prod once the chart is built as chart building does require running lots of queries which might be expensive against a larger dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] imbra edited a comment on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
imbra edited a comment on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-1022432488
+1 on this issue, same behavior as @ValentinC-BR described (except for version(s) being 1.32 and 1.4.0). This worked in 1.2. Was the design changed or is this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ChengzhiZhao commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ChengzhiZhao commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-991211470
+1 on this one. This is still a very useful feature, we have multiple environments with similar columns and it saves a lot of time copying from an existing chart to a new one in the old version. To us, it is users' responsibility to validate after copying and superset can provide error would be helpful. Could we should give warning if the schema somehow doesn't match but still enable this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ValentinC-BR commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ValentinC-BR commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-941976431
What's more, we could previously (in v.1.1) change the datasource and use a pretty different table, and only the missing column was "broken". All other config parameters (dimensions to group by, filters, etc.) remained functional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] imbra commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
imbra commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-1022432488
+1 on this issue, same behavior as @ValentinC-BR described (except for version 1.32). This worked in 1.2. Has the design changed or is this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
eschutho commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-941733375
@ValentinC-BR do your two datasets have the same metrics available? If you select a metric for one dataset for example and then switch datasets and that metric doesn't exist, it will clear out the field, because that metric is not available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-961335471
That's an interesting use case. My recollection (which I'll try to confirm) is that the nuking of the fields when switching dataset is by design. Almost always, a full reset is in order to prevent things from breaking. But, we can certainly take a look at adding/enhancing logic here to clear things only *if* there's not an (exact?) match of schema. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
eschutho commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-941733375
@ValentinC-BR do your two datasets have the same metrics available? If you select a metric for one dataset for example and then switch datasets and that metric doesn't exist, it will clear out the field, because that metric is not available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-rc commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
cccs-rc commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-942336492
I've seen the same behaviour when migrating a user's charts to point to a new dataset (identical to the previous dataset, but backed by a different database). I didn't even realize it was a bug! Just thought it was a bit of UX that could be improved in the future. It would be great if we could easily point charts to new datasets without the config getting wiped out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ValentinC-BR commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ValentinC-BR commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-941973875
Yes, they are completely identical (we generate one dataset for each of our customers).
All these datasets have the exact same structure.
And all these datasets do not have any metric (apart from the default "count" metric).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] imbra edited a comment on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
imbra edited a comment on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-1022432488
+1 on this issue, same behavior as @ValentinC-BR described (except for version being 1.32). This worked in 1.2. Has the design changed or is this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ValentinC-BR commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ValentinC-BR commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-941973875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ValentinC-BR commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ValentinC-BR commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-937692083
Issue reported on that thread : https://apache-superset.slack.com/archives/C0169MXN3HB/p1633519315003000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
eschutho commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-949937247
cc @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
eschutho commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-949931426
@villebro what do you know about this feature in 1.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] imbra edited a comment on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
imbra edited a comment on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-1022432488
+1 on this issue, same behavior as @ValentinC-BR described (except for version being 1.32). This worked in 1.2. Was the design changed or is this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ValentinC-BR commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ValentinC-BR commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-937692083
Issue reported on that thread : https://apache-superset.slack.com/archives/C0169MXN3HB/p1633519315003000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-961335471
That's an interesting use case. My recollection (which I'll try to confirm) is that the nuking of the fields when switching dataset is by design. Almost always, a full reset is in order to prevent things from breaking. But, we can certainly take a look at adding/enhancing logic here to clear things only *if* there's not an (exact?) match of schema. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho edited a comment on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-949931426
Thank you for the info/feedback on that, @ValentinC-BR. @villebro what do you know about this feature in 1.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ChengzhiZhao commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
ChengzhiZhao commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-991211470
+1 on this one. This is still a very useful feature, we have multiple environments with similar columns and it saves a lot of time copying from an existing chart to a new one in the old version. To us, it is users' responsibility to validate after copying and superset can provide error would be helpful. Could we should give warning if the schema somehow doesn't match but still enable this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-991207552
+1 on this issue, it's quite common for orgs to have multiple datasets that are identical in schema but different data size (eg, test, staging, production). A common workflow is to build charts against a test dataset then switch it over to prod once the chart is built as chart building does require running lots of queries which might be expensive against a larger dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-993673227
Hi! Hope I am understanding the problem well (if not - let me know) and would like to propose solution.
When user is changing dataset or chart type, by default we keep the control panel/chart settings if possible, but we would give them a possibility to clear the form. There may be cases in which the settings would be lost (controls do not match, etc). I think having two types of banners in the control panel could help.
_In short this would be the solution (components):_
_Flow and placement:_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-961335471
That's an interesting use case. My recollection (which I'll try to confirm) is that the nuking of the fields when switching dataset is by design. Almost always, a full reset is in order to prevent things from breaking. But, we can certainly take a look at adding/enhancing logic here to clear things only *if* there's not an (exact?) match of schema. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-rc commented on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
cccs-rc commented on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-942336492
I've seen the same behaviour when migrating a user's charts to point to a new dataset (identical to the previous dataset, but backed by a different database). I didn't even realize it was a bug! Just thought it was a bit of UX that could be improved in the future. It would be great if we could easily point charts to new datasets without the config getting wiped out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho edited a comment on issue #17010: Chart config is reset when changing the datasource
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on issue #17010:
URL: https://github.com/apache/superset/issues/17010#issuecomment-949931426
Thank you for the info/feedback on that, @ValentinC-BR. @villebro what do you know about this feature in 1.1 and what has changed or is this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org