[jira] [Commented] (YUNIKORN-151) TestUnManagedSubQueues fails

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105898#comment-17105898 ] 

Wilfred Spiegelenburg commented on YUNIKORN-151:
------------------------------------------------

The failure is in this check:
{code}
if leaf.IsDraining() || parent.IsDraining() {
t.Errorf("queues are marked for removal (draining state not for unmanaged queues)")
}
{code}
The parent should be set to draining (true) as it is a managed queue and the leaf is not draining (false) as it is an unmanaged queue.
That means the check should be for {{!parent.isDraining()}}

not sure why this has not failed before...

> TestUnManagedSubQueues fails
> ----------------------------
>
>                 Key: YUNIKORN-151
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-151
>             Project: Apache YuniKorn
>          Issue Type: Test
>          Components: test - unit
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>
> --- FAIL: TestUnManagedSubQueues (0.00s)
>     queue_info_test.go:243: queues are marked for removal (draining state not for unmanaged queues)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org