You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/06 02:30:28 UTC
[GitHub] [spark] beliefer commented on a diff in pull request #36662: [SPARK-39286][DOC] Update documentation for the decode function
beliefer commented on code in PR #36662:
URL: https://github.com/apache/spark/pull/36662#discussion_r889782405
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2504,9 +2504,10 @@ object Decode {
usage = """
_FUNC_(bin, charset) - Decodes the first argument using the second argument character set.
- _FUNC_(expr, search, result [, search, result ] ... [, default]) - Decode compares expr
- to each search value one by one. If expr is equal to a search, returns the corresponding result.
- If no match is found, then Oracle returns default. If default is omitted, returns null.
+ _FUNC_(expr, search, result [, search, result ] ... [, default]) - Compares expr
+ to each search value in order. If expr is equal to a search value, _FUNC_ returns
+ the corresponding result. If no match is found, then it returns default. If default
Review Comment:
```suggestion
the corresponding result. If no match is found, returns default. If default
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2504,9 +2504,10 @@ object Decode {
usage = """
_FUNC_(bin, charset) - Decodes the first argument using the second argument character set.
- _FUNC_(expr, search, result [, search, result ] ... [, default]) - Decode compares expr
- to each search value one by one. If expr is equal to a search, returns the corresponding result.
- If no match is found, then Oracle returns default. If default is omitted, returns null.
+ _FUNC_(expr, search, result [, search, result ] ... [, default]) - Compares expr
+ to each search value in order. If expr is equal to a search value, _FUNC_ returns
Review Comment:
```suggestion
to each search value in order. If expr is equal to a search value, returns
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org