[GitHub] [beam] ibzib commented on a change in pull request #14222: [BEAM-10943] Add builtin functions in the Calcite planner.

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #14222:
URL: https://github.com/apache/beam/pull/14222#discussion_r593523153



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/CalciteQueryPlanner.java
##########
@@ -92,8 +95,20 @@ public CalciteQueryPlanner(JdbcConnection connection, Collection<RuleSet> ruleSe
         @Override
         public QueryPlanner createPlanner(
             JdbcConnection jdbcConnection, Collection<RuleSet> ruleSets) {
+          loadBuiltinFunctions(jdbcConnection);

Review comment:
       They don't. That's the point of this PR. The functions provided by `BeamBuiltinFunctionProvider` are completely unused in ZetaSQL, so I figured we don't want them in the catalog in the first place. Otherwise, when I add functions from the jdbcConnection to the ZetaSQL catalog, I will have to have some other way to filter out builtins, or else they will conflict with the ZetaSQL builtins that are actually used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org