You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/06/23 16:28:30 UTC
Review Request: format cloudstackTestClient
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12055/
-----------------------------------------------------------
Review request for cloudstack and Sebastien Goasguen.
Description
-------
format cloudstackTestClient
This addresses bug CLOUDSTACK-3096.
Diffs
-----
tools/marvin/marvin/cloudstackTestClient.py 37380d6
Diff: https://reviews.apache.org/r/12055/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request: format cloudstackTestClient
Posted by daan Hoogland <da...@gmail.com>.
> On June 23, 2013, 3:35 p.m., Sebastien Goasguen wrote:
> > This was already patched in https://reviews.apache.org/r/12051/
> > You are missing testCaseExecuteEngine, I think you attached the wrong patch to 12051.
> > So now we are only missing the testCaseExecuteEngine
You are right, I fixed this in https://reviews.apache.org/r/12051/ for tracability.
guess i suffered an assembly line syndrome
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12055/#review22305
-----------------------------------------------------------
On June 23, 2013, 2:28 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12055/
> -----------------------------------------------------------
>
> (Updated June 23, 2013, 2:28 p.m.)
>
>
> Review request for cloudstack and Sebastien Goasguen.
>
>
> Description
> -------
>
> format cloudstackTestClient
>
>
> This addresses bug CLOUDSTACK-3096.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 37380d6
>
> Diff: https://reviews.apache.org/r/12055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request: format cloudstackTestClient
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12055/#review22305
-----------------------------------------------------------
This was already patched in https://reviews.apache.org/r/12051/
You are missing testCaseExecuteEngine, I think you attached the wrong patch to 12051.
So now we are only missing the testCaseExecuteEngine
- Sebastien Goasguen
On June 23, 2013, 2:28 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12055/
> -----------------------------------------------------------
>
> (Updated June 23, 2013, 2:28 p.m.)
>
>
> Review request for cloudstack and Sebastien Goasguen.
>
>
> Description
> -------
>
> format cloudstackTestClient
>
>
> This addresses bug CLOUDSTACK-3096.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 37380d6
>
> Diff: https://reviews.apache.org/r/12055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request: format cloudstackTestClient
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12055/#review22308
-----------------------------------------------------------
I guess you can discard this one...
since I applied the patch via 12051 as well...
- Sebastien Goasguen
On June 23, 2013, 2:28 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12055/
> -----------------------------------------------------------
>
> (Updated June 23, 2013, 2:28 p.m.)
>
>
> Review request for cloudstack and Sebastien Goasguen.
>
>
> Description
> -------
>
> format cloudstackTestClient
>
>
> This addresses bug CLOUDSTACK-3096.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 37380d6
>
> Diff: https://reviews.apache.org/r/12055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>