You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/03/26 19:47:43 UTC
Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang.
Bugs: CLOUDSTACK-6227
https://issues.apache.org/jira/browse/CLOUDSTACK-6227
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
*: tooltip is also enabled showing the original non-ellipsed value
Diffs
-----
ui/css/cloudstack3.css 4aab13b
ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
ui/scripts/accounts.js aff780e
ui/scripts/ui/widgets/detailView.js 4c5aeea
Diff: https://reviews.apache.org/r/19695/diff/
Testing
-------
Thanks,
Gabor Apati-Nagy
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/#review38918
-----------------------------------------------------------
Commit 9b16a6dfdc827fbeafde75ee4a1d027cacd2f4be in cloudstack's branch refs/heads/master from Brian Federle
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9b16a6d ]
CLOUDSTACK-6227: Don't show API/secret key fields in quickview
- ASF Subversion and Git Services
On March 28, 2014, 2:29 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19695/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:29 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-6227
> https://issues.apache.org/jira/browse/CLOUDSTACK-6227
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
> DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
> *: tooltip is also enabled showing the original non-ellipsed value
>
>
> Diffs
> -----
>
> ui/css/cloudstack3.css 9789eda
> ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
> ui/scripts/accounts.js aff780e
> ui/scripts/ui/widgets/detailView.js 4c5aeea
>
> Diff: https://reviews.apache.org/r/19695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/#review38913
-----------------------------------------------------------
Commit e65d6bd3a8e893280a0d14a68940ce45cd40b616 in cloudstack's branch refs/heads/master from Gabor Apati-Nagy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e65d6bd ]
CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
DetailView widget now supports bool isCopyPaste property that can be set
for fields. If this is set to true, the text of this field is displayed
using ellipsis formatting* and a copy-paste icon is available right next
to it. On clicking this icon, the full text is displayed
*: tooltip is also enabled showing the original non-ellipsed value
- ASF Subversion and Git Services
On March 28, 2014, 2:29 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19695/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:29 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-6227
> https://issues.apache.org/jira/browse/CLOUDSTACK-6227
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
> DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
> *: tooltip is also enabled showing the original non-ellipsed value
>
>
> Diffs
> -----
>
> ui/css/cloudstack3.css 9789eda
> ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
> ui/scripts/accounts.js aff780e
> ui/scripts/ui/widgets/detailView.js 4c5aeea
>
> Diff: https://reviews.apache.org/r/19695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/#review38912
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On March 28, 2014, 2:29 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19695/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:29 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-6227
> https://issues.apache.org/jira/browse/CLOUDSTACK-6227
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
> DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
> *: tooltip is also enabled showing the original non-ellipsed value
>
>
> Diffs
> -----
>
> ui/css/cloudstack3.css 9789eda
> ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
> ui/scripts/accounts.js aff780e
> ui/scripts/ui/widgets/detailView.js 4c5aeea
>
> Diff: https://reviews.apache.org/r/19695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/#review38917
-----------------------------------------------------------
Commit 61a0c128a741d39b118116482abbe5e56243dfce in cloudstack's branch refs/heads/4.4 from Brian Federle
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=61a0c12 ]
CLOUDSTACK-6227: Don't show API/secret key fields in quickview
- ASF Subversion and Git Services
On March 28, 2014, 2:29 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19695/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:29 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-6227
> https://issues.apache.org/jira/browse/CLOUDSTACK-6227
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
> DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
> *: tooltip is also enabled showing the original non-ellipsed value
>
>
> Diffs
> -----
>
> ui/css/cloudstack3.css 9789eda
> ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
> ui/scripts/accounts.js aff780e
> ui/scripts/ui/widgets/detailView.js 4c5aeea
>
> Diff: https://reviews.apache.org/r/19695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/#review38914
-----------------------------------------------------------
Commit 6d7978ea457404bd41149bd9d9666a4960fe8c61 in cloudstack's branch refs/heads/4.4 from Gabor Apati-Nagy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6d7978e ]
CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
DetailView widget now supports bool isCopyPaste property that can be set
for fields. If this is set to true, the text of this field is displayed
using ellipsis formatting* and a copy-paste icon is available right next
to it. On clicking this icon, the full text is displayed
*: tooltip is also enabled showing the original non-ellipsed value
- ASF Subversion and Git Services
On March 28, 2014, 2:29 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19695/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:29 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-6227
> https://issues.apache.org/jira/browse/CLOUDSTACK-6227
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
> DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
> *: tooltip is also enabled showing the original non-ellipsed value
>
>
> Diffs
> -----
>
> ui/css/cloudstack3.css 9789eda
> ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
> ui/scripts/accounts.js aff780e
> ui/scripts/ui/widgets/detailView.js 4c5aeea
>
> Diff: https://reviews.apache.org/r/19695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by Gabor Apati-Nagy <ga...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/
-----------------------------------------------------------
(Updated March 28, 2014, 2:29 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Changes
-------
Hey Brian, I created a new diff using 'git format-patch -1'. Thanks
Bugs: CLOUDSTACK-6227
https://issues.apache.org/jira/browse/CLOUDSTACK-6227
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
*: tooltip is also enabled showing the original non-ellipsed value
Diffs (updated)
-----
ui/css/cloudstack3.css 9789eda
ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
ui/scripts/accounts.js aff780e
ui/scripts/ui/widgets/detailView.js 4c5aeea
Diff: https://reviews.apache.org/r/19695/diff/
Testing
-------
Thanks,
Gabor Apati-Nagy
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail
view fields)
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19695/#review38824
-----------------------------------------------------------
Hey Gabor, for some reason I don't see the icon next to the fields you added isCopyPaste to (api/secret key). I think the diff is missing sprites.png.
Can you try creating the patch via git-format-patch -1 <your commit id)? I think it may have been an issue because it was a binary file.
- Brian Federle
On March 26, 2014, 6:47 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19695/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 6:47 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-6227
> https://issues.apache.org/jira/browse/CLOUDSTACK-6227
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6227 (Add copy-paste support for detail view fields):
> DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value.
> *: tooltip is also enabled showing the original non-ellipsed value
>
>
> Diffs
> -----
>
> ui/css/cloudstack3.css 4aab13b
> ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b
> ui/scripts/accounts.js aff780e
> ui/scripts/ui/widgets/detailView.js 4c5aeea
>
> Diff: https://reviews.apache.org/r/19695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>