[GitHub] [pulsar] congbobo184 commented on a change in pull request #4960: Consumer subscribe with AutoConsumeSchema will throw npe

[GitBox <gi...@apache.org>]

congbobo184 commented on a change in pull request #4960: Consumer subscribe with AutoConsumeSchema will throw npe 
URL: https://github.com/apache/pulsar/pull/4960#discussion_r316019654
 
 

 ##########
 File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/schema/SchemaTest.java
 ##########
 @@ -130,38 +131,33 @@ public void testMultiVersionSchema() throws Exception {
                 tenant + "/" + namespace,
                 Sets.newHashSet(pulsarCluster.getClusterName())
         );
-
-        // Create a topic with `Person`
-        try (Producer<Person> producer = client.newProducer(Schema.AVRO(
+        Producer<Person> producer = client.newProducer(Schema.AVRO(
 
 Review comment:
   we need to produce message after consumer subscribe and send should outside the try block, so we can't use try but we need to close the producer and consumer when end the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services