You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/24 05:45:46 UTC
[GitHub] [arrow] kou opened a new pull request, #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
kou opened a new pull request, #34325:
URL: https://github.com/apache/arrow/pull/34325
### Rationale for this change
`std::set(iterator, iterator)` doesn't work with old g++ on Ubuntu 18.04:
FAILED: src/arrow/util/CMakeFiles/arrow-utility-test.dir/rows_to_batches_test.cc.o
c++ ... -std=c++1z ... -c /arrow/cpp/src/arrow/util/rows_to_batches_test.cc
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc: In lambda function:
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:85:61: error: class template argument deduction failed:
return std::set(std::begin(s.values), std::end(s.values));
^
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:85:61: error: no matching function for call to 'set(std::vector<int>::const_iterator, std::vector<int>::const_iterator)'
In file included from /usr/include/c++/7/set:61:0,
from googletest_ep-prefix/include/gtest/internal/gtest-internal.h:60,
from googletest_ep-prefix/include/gtest/gtest.h:62,
from /arrow/cpp/src/arrow/util/rows_to_batches_test.cc:20:
/usr/include/c++/7/bits/stl_set.h:261:2: note: candidate: template<class _Key, class _Compare, class _Alloc, class _InputIterator> set(_InputIterator, _InputIterator, const _Alloc&)-> std::set<_Key, _Compare, _Alloc>
set(_InputIterator __first, _InputIterator __last,
^~~
/usr/include/c++/7/bits/stl_set.h:261:2: note: template argument deduction/substitution failed:
/arrow/cpp/src/arrow/util/rows_to_batches_test.cc:85:61: note: candidate expects 3 arguments, 2 provided
return std::set(std::begin(s.values), std::end(s.values));
^
In file included from /usr/include/c++/7/set:61:0,
from googletest_ep-prefix/include/gtest/internal/gtest-internal.h:60,
from googletest_ep-prefix/include/gtest/gtest.h:62,
from /arrow/cpp/src/arrow/util/rows_to_batches_test.cc:20:
/usr/include/c++/7/bits/stl_set.h:255:7: note: candidate: template<class _Key, class _Compare, class _Alloc> set(std::initializer_list<_Tp>, const allocator_type&)-> std::set<_Key, _Compare, _Alloc>
set(initializer_list<value_type> __l, const allocator_type& __a)
^~~
...
### What changes are included in this PR?
Specify type explicitly.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1442843230
Revision: 5b19ca3c48805edf54d62ede887ccee971a29e90
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2bf40db264](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2bf40db264)
|Task|Status|
|----|------|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4259754159/jobs/7412254363)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4259754969/jobs/7412255759)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4259754439/jobs/7412254780)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1442841690
:warning: GitHub issue #34324 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1444603676
Benchmark runs are scheduled for baseline = 8e09f8c5dd8935eed830127b7d73aa034092ca4c and contender = e8e50a3ca96ec8eb2f2beb383cf9005ce1c93486. e8e50a3ca96ec8eb2f2beb383cf9005ce1c93486 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1b593cb9847e41b18bcb0359a617873a...7c29bc00f8224a889ca6528f23018623/)
[Failed :arrow_down:0.31% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/000d167b25064c8ca1cd71758d221b70...9b8e38ed69b2453795c62ac714c47712/)
[Finished :arrow_down:5.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6a6ec0694820498e8053a55d7f6f8e40...73e3734f0dde4afa852e1b6689412f85/)
[Finished :arrow_down:0.25% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ee882053df4644d1a39c54cd49819286...32b8c3f573fb494ca595cdbe9c19951c/)
Buildkite builds:
[Finished] [`e8e50a3c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2433)
[Failed] [`e8e50a3c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2463)
[Finished] [`e8e50a3c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2430)
[Finished] [`e8e50a3c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2454)
[Finished] [`8e09f8c5` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2432)
[Failed] [`8e09f8c5` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2462)
[Finished] [`8e09f8c5` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2429)
[Finished] [`8e09f8c5` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2453)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1444604678
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6a6ec0694820498e8053a55d7f6f8e40...73e3734f0dde4afa852e1b6689412f85/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1442991304
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34325:
URL: https://github.com/apache/arrow/pull/34325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1442841666
* Closes: #34324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34325: GH-34324: [CI][C++] Specify set element type explicitly for old g++
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34325:
URL: https://github.com/apache/arrow/pull/34325#issuecomment-1442841744
@github-actions crossbow submit test-ubuntu-18.04-cpp*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org