You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "rpuch (via GitHub)" <gi...@apache.org> on 2024/10/30 14:19:26 UTC
[PR] IGNITE-23579 Improve diagnostics of CMG/MG disaster recovery [ignite-3]
rpuch opened a new pull request, #4658:
URL: https://github.com/apache/ignite-3/pull/4658
https://issues.apache.org/jira/browse/IGNITE-23579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23579 Improve diagnostics of CMG/MG disaster recovery [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #4658:
URL: https://github.com/apache/ignite-3/pull/4658#discussion_r1822806824
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteServerImpl.java:
##########
@@ -119,6 +119,14 @@ public class IgniteServerImpl implements IgniteServer {
@Nullable
private CompletableFuture<Void> restartOrShutdownFuture;
+ /**
+ * Future of the last internal restart future ({@code null} if no internal restarts where made).
+ *
+ * <p>Guarded by {@link #restartOrShutdownMutex}.
+ */
+ @Nullable
+ private CompletableFuture<Void> restartFuture;
Review Comment:
In tests, we need to wait till restart gets initiated and then for it to finish. Currently, this is implemented by returning `null` to signal that no restart was initiated yet and the future when it is initiated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23579 Improve diagnostics of CMG/MG disaster recovery [ignite-3]
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #4658:
URL: https://github.com/apache/ignite-3/pull/4658#discussion_r1822789769
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteServerImpl.java:
##########
@@ -119,6 +119,14 @@ public class IgniteServerImpl implements IgniteServer {
@Nullable
private CompletableFuture<Void> restartOrShutdownFuture;
+ /**
+ * Future of the last internal restart future ({@code null} if no internal restarts where made).
+ *
+ * <p>Guarded by {@link #restartOrShutdownMutex}.
+ */
+ @Nullable
+ private CompletableFuture<Void> restartFuture;
Review Comment:
Do we really need to know if restart has never been issued? Can we initialize this future with `nullCompletedFuture`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23579 Improve diagnostics of CMG/MG disaster recovery [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch merged PR #4658:
URL: https://github.com/apache/ignite-3/pull/4658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org