You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2010/11/30 20:29:24 UTC
svn commit: r1040719 -
/wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
Author: mgrigorov
Date: Tue Nov 30 19:29:24 2010
New Revision: 1040719
URL: http://svn.apache.org/viewvc?rev=1040719&view=rev
Log:
Remove a TODO.
Page#getPageParameters() is used all over the code without checks for null.
Empty PageParameters object is 142 bytes and Page object has only one instance of it (if the client code calls super(pageParameters)...)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java?rev=1040719&r1=1040718&r2=1040719&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java Tue Nov 30 19:29:24 2010
@@ -276,7 +276,7 @@ public abstract class Page extends Marku
super(null, model);
if (parameters == null)
- { // TODO WICKET-NG is this necessary or can we keep the field as null to save space?
+ {
pageParameters = new PageParameters();
}
else