You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 16:36:12 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #11865: ARROW-14976: [Dev][Archery] Fail early if no benchmark found

pitrou commented on a change in pull request #11865:
URL: https://github.com/apache/arrow/pull/11865#discussion_r763174999



##########
File path: dev/archery/archery/benchmark/runner.py
##########
@@ -180,8 +181,12 @@ def suites(self):
                              .format(suite_name))
                 continue
 
+            suite_found = True
             yield suite
 
+        if not suite_found:
+            raise ValueError("No benchmark matches the filter")

Review comment:
       Nit: "the suite filter" perhaps?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org