You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2016/03/18 23:52:48 UTC
[DISCUSS] Cordova-common@1.1.1
I propose a patch release of cordova-common. Thoughts?
Changes:
* CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
duplicate entries)
* CB-10694 - Platform-specific configuration preferences don't override
global settings
* CB-9264 - Duplicate entries in config.xml
* CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
* CB-10662 Add tests for ConfigParser.getStaticResources
* CB-10622 fix target attribute being ignored for images in config.xml.
This closes #392
* CB-10583 Protect plugin preferences from adding extra Array properties.
This closes #400
* CB-10626 Incremented cordova-common package version to -dev
Issue: https://issues.apache.org/jira/browse/CB-10911
Re: [DISCUSS] Cordova-common@1.1.1
Posted by Carlos Santana <cs...@gmail.com>.
Sounds good
On Fri, Mar 18, 2016 at 7:21 PM Steven Gill <st...@gmail.com> wrote:
> haha it would make my life easier. Too late now. I didn't include it in the
> tools release but in hindsight I should have.
>
> Tools release will pick up this release since cordova-common dependency is
> 1.1.x in cordova-lib.
>
> This cordova-common release has more to do with platforms anyways. The
> changes in here need to be added to platforms for the fixes we want. Other
> tools don't necessarily need this change to be released. They should come
> out around the same time though.
>
> -Steve
>
>
>
> On Fri, Mar 18, 2016 at 4:03 PM, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > Why cordova-common not included with the Tools release?
> > Does the cordova-lib that you sent out to vote contains this fixes? I
> > assuming it doesn't just want to be sure
> >
> > I think it can be release separately like any of the others, but
> releasing
> > it with the Tools would make it easier for person doing the Tools release
> > in this case you Steve :-)
> >
> >
> > On Fri, Mar 18, 2016 at 6:53 PM Steven Gill <st...@gmail.com>
> > wrote:
> >
> > > I propose a patch release of cordova-common. Thoughts?
> > >
> > > Changes:
> > > * CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
> > > duplicate entries)
> > > * CB-10694 - Platform-specific configuration preferences don't override
> > > global settings
> > > * CB-9264 - Duplicate entries in config.xml
> > > * CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
> > > * CB-10662 Add tests for ConfigParser.getStaticResources
> > > * CB-10622 fix target attribute being ignored for images in config.xml.
> > > This closes #392
> > > * CB-10583 Protect plugin preferences from adding extra Array
> properties.
> > > This closes #400
> > > * CB-10626 Incremented cordova-common package version to -dev
> > >
> > > Issue: https://issues.apache.org/jira/browse/CB-10911
> > >
> >
>
Re: [DISCUSS] Cordova-common@1.1.1
Posted by Steven Gill <st...@gmail.com>.
haha it would make my life easier. Too late now. I didn't include it in the
tools release but in hindsight I should have.
Tools release will pick up this release since cordova-common dependency is
1.1.x in cordova-lib.
This cordova-common release has more to do with platforms anyways. The
changes in here need to be added to platforms for the fixes we want. Other
tools don't necessarily need this change to be released. They should come
out around the same time though.
-Steve
On Fri, Mar 18, 2016 at 4:03 PM, Carlos Santana <cs...@gmail.com>
wrote:
> Why cordova-common not included with the Tools release?
> Does the cordova-lib that you sent out to vote contains this fixes? I
> assuming it doesn't just want to be sure
>
> I think it can be release separately like any of the others, but releasing
> it with the Tools would make it easier for person doing the Tools release
> in this case you Steve :-)
>
>
> On Fri, Mar 18, 2016 at 6:53 PM Steven Gill <st...@gmail.com>
> wrote:
>
> > I propose a patch release of cordova-common. Thoughts?
> >
> > Changes:
> > * CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
> > duplicate entries)
> > * CB-10694 - Platform-specific configuration preferences don't override
> > global settings
> > * CB-9264 - Duplicate entries in config.xml
> > * CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
> > * CB-10662 Add tests for ConfigParser.getStaticResources
> > * CB-10622 fix target attribute being ignored for images in config.xml.
> > This closes #392
> > * CB-10583 Protect plugin preferences from adding extra Array properties.
> > This closes #400
> > * CB-10626 Incremented cordova-common package version to -dev
> >
> > Issue: https://issues.apache.org/jira/browse/CB-10911
> >
>
Re: [DISCUSS] Cordova-common@1.1.1
Posted by Carlos Santana <cs...@gmail.com>.
Why cordova-common not included with the Tools release?
Does the cordova-lib that you sent out to vote contains this fixes? I
assuming it doesn't just want to be sure
I think it can be release separately like any of the others, but releasing
it with the Tools would make it easier for person doing the Tools release
in this case you Steve :-)
On Fri, Mar 18, 2016 at 6:53 PM Steven Gill <st...@gmail.com> wrote:
> I propose a patch release of cordova-common. Thoughts?
>
> Changes:
> * CB-10694 - Update test to reflect merging of CB-9264 fix (removal of
> duplicate entries)
> * CB-10694 - Platform-specific configuration preferences don't override
> global settings
> * CB-9264 - Duplicate entries in config.xml
> * CB-10791 Add adjustLoggerLevel to cordova-common.CordovaLogger
> * CB-10662 Add tests for ConfigParser.getStaticResources
> * CB-10622 fix target attribute being ignored for images in config.xml.
> This closes #392
> * CB-10583 Protect plugin preferences from adding extra Array properties.
> This closes #400
> * CB-10626 Incremented cordova-common package version to -dev
>
> Issue: https://issues.apache.org/jira/browse/CB-10911
>