[GitHub] [hive] pkumarsinha commented on a change in pull request #1345: HIVE-23961 : Enable external table replication by default

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #1345:
URL: https://github.com/apache/hive/pull/1345#discussion_r464868111



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -564,7 +564,7 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
     REPL_ADD_RAW_RESERVED_NAMESPACE("hive.repl.add.raw.reserved.namespace", false,
         "For TDE with same encryption keys on source and target, allow Distcp super user to access \n"
             + "the raw bytes from filesystem without decrypting on source and then encrypting on target."),
-    REPL_INCLUDE_EXTERNAL_TABLES("hive.repl.include.external.tables", false,
+    REPL_INCLUDE_EXTERNAL_TABLES("hive.repl.include.external.tables", true,

Review comment:
       nit: Should we do cleanup and remove the usage of ReplicationTestUtils.includeExternalTableClause() with true value passed?
   ReplicationTestUtils.includeExternalTableClause(true);




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org