[GitHub] [incubator-doris] zenoyang commented on pull request #6448: [Bug] Regularly clean up old DeleteInfos in the DeleteHandler

[GitBox <gi...@apache.org>]

zenoyang commented on pull request #6448:
URL: https://github.com/apache/incubator-doris/pull/6448#issuecomment-900910166


   > Hi @zenoyang thanks for your PR. This is indeed a problem.
   > But there some thing that you need to know:
   > 
   > 1. The `labelCleaner` thread is running on all FEs, each FE will clean its own `deleteInfos`. So don't need to write a edit log `OP_REMOVE_OLD_DELETE_INFO` to "tell" other FE to clean the delete infos.
   > 2. Once the `labelCleaner` thread cleans the delete infos on each FE. What we need to take care is to clean the delete infos in meta replay logic. Eg, after calling `DeleteHandler.read()` method, we should clean the delete info actively, so that the meta image won't contains expired delete infos.
   > 
   > This logic is a bit convoluted. If you don't understand something, welcome to communicate.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org