[GitHub] spark pull request #18528: [SPARK-13041][Mesos] Adds sandbox uri to spark di...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18528#discussion_r130539277
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala ---
    @@ -76,6 +77,17 @@ private[mesos] class MesosClusterPage(parent: MesosClusterUI) extends WebUIPage(
     
       private def driverRow(state: MesosClusterSubmissionState): Seq[Node] = {
         val id = state.driverDescription.submissionId
    +    val proxy = parent.conf.getOption("spark.mesos.proxy.base_url")
    +
    +    val sandboxCol = if (proxy.isDefined) {
    +      val clusterSchedulerId = parent.scheduler.getSchedulerState().frameworkId
    +      val sandBoxUri = s"${proxy.get}/#/agents/${state.slaveId.getValue}/frameworks/" +
    +        s"${clusterSchedulerId}/executors/${id}/browse"
    +      <a href={sandBoxUri}>Sandbox</a>
    +    }
    +    else {
    --- End diff --
    
    Nit: pull up to previous line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org