[GitHub] [james-project] chibenwa commented on a change in pull request #278: JAMES-3431 Optional DSN support for SMTP server

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #278:
URL: https://github.com/apache/james-project/pull/278#discussion_r540720313



##########
File path: protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HeloHook.java
##########
@@ -19,12 +19,19 @@
 
 package org.apache.james.protocols.smtp.hook;
 
+import java.util.Set;
+
 import org.apache.james.protocols.smtp.SMTPSession;
 
+import com.google.common.collect.ImmutableSet;
+
 /**
  * Implement this interfaces to hook in the HELO Command
  */
 public interface HeloHook extends Hook {
+    default Set<String> implementedEsmtpFeatures() {

Review comment:
       We need Java Doc here!

##########
File path: protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/RcptHook.java
##########
@@ -51,4 +62,8 @@ default HookResult doRcpt(SMTPSession session, MaybeSender sender, MailAddress r
         return doRcpt(session, sender.asOptional().orElse(null), rcpt);
     }
 
+    default HookResult doRcpt(SMTPSession session, MaybeSender sender, MailAddress rcpt, Map<String, String> parameters) {

Review comment:
       We need Java doc here!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org