You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/25 21:48:46 UTC
[GitHub] [couchdb] nickva opened a new pull request #3460: Improve retryable FDB error handling
nickva opened a new pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460
After running the Elixir suite under "buggify" mode, noticed we didn't handle retryable errors very well. In some places we handled a few more errors like 1009 and 1007, while in others only 1007. There was also some inconsistency between using numeric codes and constants defined in `fabric2.hrl`.
To make retryable error handling more systematic, add most of them as constants to `fabric2.hrl`, along with a guard. Since some of the error names were getting a bit too generic, added the `FDB` prefix to all of them.
Then, updated `couch_jobs`, `couch_views` and `fabric` applications to use the new definitions and the new guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460#issuecomment-807918692
@davisp ready for another look. It turns there was no need to add an include file, erlfdb already had one and I had forgotten about it. Then, including it in fabric2.hrl made it pretty easy overall. Also, set the prefix to `ERLFDB_` just to match the rest of the macros in include file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva edited a comment on pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460#issuecomment-807710073
The erlfdb pr https://github.com/apache/couchdb-erlfdb/pull/21
(will replace the commit sha link with tag in this pr after erlfdb is merged and tagged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] davisp commented on pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
davisp commented on pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460#issuecomment-807569130
What would you say to moving those `?FDB_*` and `?IS_RETRYABLE` macros to erlfdb instead of fabric2? Seems like those would be generally useful to erlfdb users in general. I'd also rename the retryable macro to `?FDB_IS_RETRYABLE` for namespacey reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460#issuecomment-807575225
@davisp both good ideas. We'll add a new include file in erlfdb and then include that in fabric2.hrl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460#issuecomment-807710073
The erlfdb pr https://github.com/apache/couchdb-erlfdb/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva removed a comment on pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
nickva removed a comment on pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460#issuecomment-807710073
The erlfdb pr https://github.com/apache/couchdb-erlfdb/pull/21
(will replace the commit sha link with tag in this pr after erlfdb is merged and tagged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3460: Improve retryable FDB error handling
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3460:
URL: https://github.com/apache/couchdb/pull/3460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org