You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/16 03:16:23 UTC
[GitHub] [iotdb] Beyyes opened a new pull request, #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Beyyes opened a new pull request, #7008:
URL: https://github.com/apache/iotdb/pull/7008
## Description
When executed remove-datanode.sh TARGET_NODE, the node status of TARGET_NODE should be marked as `REMOVING`, and the LatestRegionRouteMap should be broadcasted to assure that no more read/write requests are forwarded to this datanode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1216132016
[](https://coveralls.io/builds/51683857)
Coverage increased (+0.004%) to 41.966% when pulling **c2c2a34cca9e88ed74209b3797ca31e9d3500e5d on beyyes/remove_datanode_precedure** into **db0b6fd14f6b154c0562719e44d7fefa3b3b2607 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#discussion_r947907008
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/load/heartbeat/DataNodeHeartbeatCache.java:
##########
@@ -22,27 +22,44 @@
import java.util.LinkedList;
-/** DataNodeHeartbeatCache caches and maintains all the heartbeat data */
+/**
+ * DataNodeHeartbeatCache caches and maintains all the heartbeat data
+ *
+ * <p>TODO: This class might be split into DataNodeCache and ConfigNodeCache
+ */
public class DataNodeHeartbeatCache implements INodeCache {
- // TODO: This class might be split into DataNodeCache and ConfigNodeCache
+ // when the response time of heartbeat is more than 20s,
+ // the datanode is considered as down
+ private static final int HEARTBEAT_TIMEOUT_TIME = 20_000;
Review Comment:
fixed. and I think changing INodeCache from `Interface` to `Abstract class` is better. Because some variables are common used.
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PartitionManager.java:
##########
@@ -531,7 +532,10 @@ public Map<TConsensusGroupId, Integer> getAllLeadership() {
regionGroupCacheMap.forEach(
(consensusGroupId, regionGroupCache) -> {
if (consensusGroupId.getType().equals(TConsensusGroupType.SchemaRegion)) {
- result.put(consensusGroupId, regionGroupCache.getLeaderDataNodeId());
+ int leaderDataNodeId = regionGroupCache.getLeaderDataNodeId();
+ if (!configManager.getNodeManager().isNodeRemoving(leaderDataNodeId)) {
+ result.put(consensusGroupId, leaderDataNodeId);
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1216269463
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7008)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list) [27.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1216135089
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7008)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list) [27.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a diff in pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on code in PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#discussion_r947561839
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/NodeManager.java:
##########
@@ -569,6 +571,23 @@ public Map<Integer, Long> getAllLoadScores() {
return result;
}
+ public boolean isNodeRemoving(int dataNodeId) {
+ DataNodeHeartbeatCache cache =
+ (DataNodeHeartbeatCache) configManager.getNodeManager().getNodeCacheMap().get(dataNodeId);
+ if (cache != null) {
+ return cache.isRemoving();
+ }
+ return false;
+ }
+
+ public void setNodeRemoving(int dataNodeId) {
Review Comment:
TODO: add a interface, set node removing is false.
if procedure failed and rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #7008:
URL: https://github.com/apache/iotdb/pull/7008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#discussion_r947907252
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PartitionManager.java:
##########
@@ -544,8 +548,12 @@ public Map<TConsensusGroupId, Integer> getAllLeadership() {
regionReplicaSet.getDataNodeLocations().get(0).getDataNodeId()));
} else {
regionGroupCacheMap.forEach(
- (consensusGroupId, regionGroupCache) ->
- result.put(consensusGroupId, regionGroupCache.getLeaderDataNodeId()));
+ (consensusGroupId, regionGroupCache) -> {
+ int leaderDataNodeId = regionGroupCache.getLeaderDataNodeId();
+ if (!configManager.getNodeManager().isNodeRemoving(leaderDataNodeId)) {
+ result.put(consensusGroupId, leaderDataNodeId);
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1218944183
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7008)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list) [23.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list) [0.9% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#discussion_r947913452
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/NodeManager.java:
##########
@@ -569,6 +571,23 @@ public Map<Integer, Long> getAllLoadScores() {
return result;
}
+ public boolean isNodeRemoving(int dataNodeId) {
+ DataNodeHeartbeatCache cache =
+ (DataNodeHeartbeatCache) configManager.getNodeManager().getNodeCacheMap().get(dataNodeId);
+ if (cache != null) {
+ return cache.isRemoving();
+ }
+ return false;
+ }
+
+ public void setNodeRemoving(int dataNodeId) {
Review Comment:
change method from `setNodeRemovingStatus(int dataNodeId)` to `setNodeRemovingStatus(int dataNodeId, boolean isRemoving)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1219651126
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7008)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list) [25.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list) [0.9% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on code in PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#discussion_r947547094
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/load/heartbeat/DataNodeHeartbeatCache.java:
##########
@@ -22,27 +22,44 @@
import java.util.LinkedList;
-/** DataNodeHeartbeatCache caches and maintains all the heartbeat data */
+/**
+ * DataNodeHeartbeatCache caches and maintains all the heartbeat data
+ *
+ * <p>TODO: This class might be split into DataNodeCache and ConfigNodeCache
+ */
public class DataNodeHeartbeatCache implements INodeCache {
- // TODO: This class might be split into DataNodeCache and ConfigNodeCache
+ // when the response time of heartbeat is more than 20s,
+ // the datanode is considered as down
+ private static final int HEARTBEAT_TIMEOUT_TIME = 20_000;
Review Comment:
The HEARTBEAT_TIMEOUT_TIME can be moved to INodeCache since it's also used in ConfigNodeHeartbeatCache
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PartitionManager.java:
##########
@@ -531,7 +532,10 @@ public Map<TConsensusGroupId, Integer> getAllLeadership() {
regionGroupCacheMap.forEach(
(consensusGroupId, regionGroupCache) -> {
if (consensusGroupId.getType().equals(TConsensusGroupType.SchemaRegion)) {
- result.put(consensusGroupId, regionGroupCache.getLeaderDataNodeId());
+ int leaderDataNodeId = regionGroupCache.getLeaderDataNodeId();
+ if (!configManager.getNodeManager().isNodeRemoving(leaderDataNodeId)) {
+ result.put(consensusGroupId, leaderDataNodeId);
+ }
Review Comment:
We'd better put -1 instead of nothing when the leaderNode happens to be in the status of Removing. This might avoid NPE.
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PartitionManager.java:
##########
@@ -544,8 +548,12 @@ public Map<TConsensusGroupId, Integer> getAllLeadership() {
regionReplicaSet.getDataNodeLocations().get(0).getDataNodeId()));
} else {
regionGroupCacheMap.forEach(
- (consensusGroupId, regionGroupCache) ->
- result.put(consensusGroupId, regionGroupCache.getLeaderDataNodeId()));
+ (consensusGroupId, regionGroupCache) -> {
+ int leaderDataNodeId = regionGroupCache.getLeaderDataNodeId();
+ if (!configManager.getNodeManager().isNodeRemoving(leaderDataNodeId)) {
+ result.put(consensusGroupId, leaderDataNodeId);
+ }
Review Comment:
We'd better put -1 instead of nothing when the leaderNode happens to be in the status of Removing. This might avoid NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1217745184
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7008)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list) [20.2% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list) [0.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7008: [IOTDB-4140] Mark the datanode as removing status when execute remove-datanode.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7008:
URL: https://github.com/apache/iotdb/pull/7008#issuecomment-1218240301
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7008)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7008&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list) [23.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7008&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org