You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Thomas Hallgren (JIRA)" <ji...@apache.org> on 2012/10/14 09:34:03 UTC
[jira] [Created] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Thomas Hallgren created HTTPCORE-317:
----------------------------------------
Summary: Source bundle for httpcore-osgi contains no source
Key: HTTPCORE-317
URL: https://issues.apache.org/jira/browse/HTTPCORE-317
Project: HttpComponents HttpCore
Issue Type: Bug
Components: HttpCore
Affects Versions: 4.2.2
Reporter: Thomas Hallgren
The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475858#comment-13475858 ]
Oleg Kalnichevski commented on HTTPCORE-317:
--------------------------------------------
I cannot make any definitive statements on behalf of Felix developers but my belief is that source code of inlined dependencies is not included in the source jar of the bundle.
Oleg
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Resolved] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-317.
----------------------------------------
Resolution: Invalid
This is apparently called dependency inlining and a far as I can tell is a very common practice [1]
---
<Embed-Dependency>*;scope=compile|runtime;inline=true</Embed-Dependency>
---
Naturally this directive does not apply to source code and some additional efforts would need to be made to copy the corresponding source files to the artifact's source jar.
At any rate this is not an issue with HttpCore but rather with maven-bundle-plugin or eclipse (depending on who you are more inclined to blame). We, as a project, have very limited means of fixing it. Please do not re-open the issue unless you are prepared to actively pursue it with maven-bundle-plugin or eclipse developers.
Oleg
[1] http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Resolved] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-317.
----------------------------------------
Resolution: Not A Problem
Thomas
The source jar contains to files because there are basically OSGi modules merely aggregate content from other modules and contain no source code beyond OSGi metadata
http://svn.apache.org/repos/asf/httpcomponents/httpcore/branches/4.2.x/httpcore-osgi/src/main/
http://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.2.x/httpclient-osgi/src/main/
This may change though with HTTPCLIENT-1238
Oleg
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Posted by "Thomas Hallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475849#comment-13475849 ]
Thomas Hallgren commented on HTTPCORE-317:
------------------------------------------
OK, so basically what you're saying is that any project that uses dependency inlining will have useless source jars?
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Comment Edited] (HTTPCORE-317) Source bundle for
httpcore-osgi contains no source
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475832#comment-13475832 ]
Oleg Kalnichevski edited comment on HTTPCORE-317 at 10/14/12 12:49 PM:
-----------------------------------------------------------------------
Thomas
The source jar contains to files because OSGi modules merely aggregate content from other modules and contain no source code beyond OSGi metadata in pom.xml
http://svn.apache.org/repos/asf/httpcomponents/httpcore/branches/4.2.x/httpcore-osgi/src/main/
http://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.2.x/httpclient-osgi/src/main/
This may change though with HTTPCLIENT-1238
Oleg
was (Author: olegk):
Thomas
The source jar contains to files because there are basically OSGi modules merely aggregate content from other modules and contain no source code beyond OSGi metadata
http://svn.apache.org/repos/asf/httpcomponents/httpcore/branches/4.2.x/httpcore-osgi/src/main/
http://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.2.x/httpclient-osgi/src/main/
This may change though with HTTPCLIENT-1238
Oleg
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Reopened] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Posted by "Thomas Hallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Hallgren reopened HTTPCORE-317:
--------------------------------------
I've never seen that kind of aggregate before. It leads to problems for tools that assumes that the httpcore-osgi-sources.jar will contain the source for httpcore-osgi.jar. Buckminster for instance, downloads the sources jar automatically and then configures the target platform correctly so that sources can be viewed in Eclipse. That doesn't work with this type of aggregation. Using SVN is cumbersome since it a) requires SVN and b) requires knowledge of what tag/branch to use to get the correlation between binary and source exactly right. I'm repoening this because I want to kindly ask you to not use this type of aggregation.
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-317) Source bundle for httpcore-osgi
contains no source
Posted by "Thomas Hallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475837#comment-13475837 ]
Thomas Hallgren commented on HTTPCORE-317:
------------------------------------------
Also, please note that the httpcore-osgi.jar contains all .class files. It's not just an aggregation.
> Source bundle for httpcore-osgi contains no source
> --------------------------------------------------
>
> Key: HTTPCORE-317
> URL: https://issues.apache.org/jira/browse/HTTPCORE-317
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.2.2
> Reporter: Thomas Hallgren
>
> The file org/apache/httpcomponents/httpcore-osgi/4.2.2/httpcore-osgi-4.2.2-sources.jar over at Maven Central contains a META-INF directory with some files but nothing more. All source files are missing.
> Same thing with the httpclient-osgi.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org