You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2023/04/15 07:14:12 UTC
[GitHub] [spark] gengliangwang opened a new pull request, #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
gengliangwang opened a new pull request, #40804:
URL: https://github.com/apache/spark/pull/40804
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Update the prerequisites for generating Python API docs:
* The command should be run under the docs directory so that the input file should be `../dev/requirements.txt`
* Remove `sudo` in the command
* Remove the version for `torch` and `torchvision`. I was getting
```
ERROR: Could not find a version that satisfies the requirement torch==1.13.1 (from versions: 2.0.0)
ERROR: No matching distribution found for torch==1.13.1
ERROR: Could not find a version that satisfies the requirement torchvision==0.14.1
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Update the prerequisites for generating Python API docs, to save troubles from other developers when generating Python Docs.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Manually try the command and new requirements.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40804:
URL: https://github.com/apache/spark/pull/40804#discussion_r1167680125
##########
docs/README.md:
##########
@@ -61,7 +61,7 @@ See also https://issues.apache.org/jira/browse/SPARK-35375.
-->
Run the following command from $SPARK_HOME:
```sh
-$ sudo pip install --upgrade -r dev/requirements.txt
+$ pip install --upgrade -r ../dev/requirements.txt
Review Comment:
It syas `Run the following command from $SPARK_HOME:` so I think `dev/requirements.txt` is a proper path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
URL: https://github.com/apache/spark/pull/40804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on code in PR #40804:
URL: https://github.com/apache/spark/pull/40804#discussion_r1167688843
##########
docs/README.md:
##########
@@ -61,7 +61,7 @@ See also https://issues.apache.org/jira/browse/SPARK-35375.
-->
Run the following command from $SPARK_HOME:
```sh
-$ sudo pip install --upgrade -r dev/requirements.txt
+$ pip install --upgrade -r ../dev/requirements.txt
Review Comment:
ok, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40804:
URL: https://github.com/apache/spark/pull/40804#discussion_r1168114565
##########
dev/requirements.txt:
##########
@@ -61,5 +61,5 @@ googleapis-common-protos-stubs==2.2.0
grpc-stubs==1.24.11
# TorchDistributor dependencies
-torch==1.13.1
-torchvision==0.14.1
+torch
+torchvision
Review Comment:
@rithwik-db fyo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40804:
URL: https://github.com/apache/spark/pull/40804#issuecomment-1510562041
@gengliangwang I just success to run this `pip install --upgrade -r dev/requirements.txt` in a clean conda env, and can not reproduce the issue related to pytorch version.
@HyukjinKwon @WeichenXu123 have you seen this version issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40804:
URL: https://github.com/apache/spark/pull/40804#issuecomment-1510625745
I haven't seen this before. but I think loosing the version restrictions looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40804:
URL: https://github.com/apache/spark/pull/40804#issuecomment-1510097573
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40804:
URL: https://github.com/apache/spark/pull/40804#discussion_r1168114565
##########
dev/requirements.txt:
##########
@@ -61,5 +61,5 @@ googleapis-common-protos-stubs==2.2.0
grpc-stubs==1.24.11
# TorchDistributor dependencies
-torch==1.13.1
-torchvision==0.14.1
+torch
+torchvision
Review Comment:
@rithwik-db fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40804:
URL: https://github.com/apache/spark/pull/40804#issuecomment-1510749953
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #40804: [SPARK-43151][DOC] Update the prerequisites for generating Python API docs
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #40804:
URL: https://github.com/apache/spark/pull/40804#issuecomment-1510722608
> @gengliangwang I just success to run this pip install --upgrade -r dev/requirements.txt in a clean conda env, and can not reproduce the issue related to pytorch version.
@zhengruifeng I am using python 3.11.2
And I am actually running with
```
pip3 install --upgrade -r dev/requirements.txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org