You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2016/09/03 22:29:26 UTC

[Issue 127100] New: Make NSIS 3.* a build requirement for building Windows installers

https://bz.apache.org/ooo/show_bug.cgi?id=127100

          Issue ID: 127100
        Issue Type: DEFECT
           Summary: Make NSIS 3.* a build requirement for building Windows
                    installers
           Product: Build Tools
           Version: 4.2.0-dev
          Hardware: PC
                OS: Windows, all
            Status: CONFIRMED
          Severity: Normal
          Priority: P5 (lowest)
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: arielch@apache.org

Currently, the build system does some weird build-time NSIS version checking to
detect the version and the Unicode support, see
http://svn.apache.org/viewvc/openoffice/trunk/main/solenv/bin/modules/installer/download.pm?view=markup#l897

We should make NSIS 3.* a build requirement at configure time when msi is among
the selected package formats. The advantage is that NSIS 3.0 comes with Unicode
support out of the box (there is no need to install the Unicode version of
NSIS), while it also fixes several issues, among them some security issues like
https://sourceforge.net/p/nsis/bugs/1125/

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127100] Make NSIS 3.* a build requirement for building Windows installers

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127100

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pescetti@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127100] Make NSIS 3.* a build requirement for building Windows installers

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127100

orcmid <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orcmid@apache.org

--- Comment #1 from orcmid <or...@apache.org> ---
(In reply to Ariel Constenla-Haile from comment #0)
> We should make NSIS 3.* a build requirement at configure time when msi is
> among the selected package formats. The advantage is that NSIS 3.0 comes
> with Unicode support out of the box (there is no need to install the Unicode
> version of NSIS), while it also fixes several issues, among them some
> security issues like https://sourceforge.net/p/nsis/bugs/1125/

It would be interesting to add this to the AOO410 branch (i.e., 4.1.2) and
confirm that the resulting installer is 4.1.2 and there is nothing else
impacted beyond the customizations that would be used with the NSIS 3.*.

This should be an easy way to confirm that a stable release that already exists
is installed essentially the same with an upgraded installer.  Then we could
merge the same patches into whatever the next release is.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127100] Make NSIS 3.* a build requirement for building Windows installers

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127100

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |TASK

-- 
You are receiving this mail because:
You are the assignee for the issue.

4.1.3_release_blocker granted: [Issue 127100] Make NSIS 3.* a build requirement for building Windows installers

Posted by bu...@apache.org.
Patricia Shanahan <pa...@acm.org> has granted  4.1.3_release_blocker:
Issue 127100: Make NSIS 3.* a build requirement for building Windows installers
https://bz.apache.org/ooo/show_bug.cgi?id=127100

[Issue 127100] Make NSIS 3.* a build requirement for building Windows installers

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127100

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|issues@openoffice.apache.or |arielch@apache.org
                   |g                           |
             Status|CONFIRMED                   |ACCEPTED

-- 
You are receiving this mail because:
You are the assignee for the issue.